Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Aug 2002 15:59:42 +0200
From:      Morten Rodal <morten@rodal.no>
To:        Eirik Nygaard <eirikn@bluezone.no>
Cc:        current@FreeBSD.ORG
Subject:   Re: Rewrite of the perl script rmuser to C
Message-ID:  <20020810135941.GF6050@slurp.rodal.no>
In-Reply-To: <20020810120239.GB1064@test.eirikn.net>
References:  <20020810120239.GB1064@test.eirikn.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--MIdTMoZhcV1D07fI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Aug 10, 2002 at 02:02:39PM +0200, Eirik Nygaard wrote:
> I have just rewritten the rmuser perl script to C, it would be=20
> great if you could take a look at it and check if everything is ok.

You should probably replace the strcpy() and strcat() with strlcpy(3) and
strlcat(3), or at least use the strncpy(3) and strncat(3). Also, sprintf()
should be replaced with snprintf(3).

Maybe close the file descriptors in the signal handlers?

>=20
> How do I get this commited?

Now that I cannot answer for :)

--

Morten Rodal

//
// PGP ID 2D75595B
// 22DE D67A 1AEA EF94 872A  9384 6D67 B50B 2D75 595B
//



--MIdTMoZhcV1D07fI
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE9VRxNbWe1Cy11WVsRAt1CAJ40d/aSFEJSlQ/GW/jXWcCvnC/D7ACgwjVo
Yv7VDTbYnpY89+0iV5i2Wr8=
=mIlW
-----END PGP SIGNATURE-----

--MIdTMoZhcV1D07fI--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020810135941.GF6050>