Date: Fri, 19 Jan 2007 21:07:10 -0500 (EST) From: Robert Krten <rk@parse.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/108133: bktr driver doesn't recognize Hauppauge WinTV Go 0x79 type; patch enclosed Message-ID: <200701200207.l0K27AVO002418@parse.com> Resent-Message-ID: <200701200250.l0K2oDtH010537@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 108133
>Category: kern
>Synopsis: bktr driver doesn't recognize Hauppauge WinTV Go 0x79 type; patch enclosed
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Jan 20 02:50:13 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Robert Krten
>Release: FreeBSD 6.2-RELEASE amd64
>Organization:
PARSE Software Devices
>Environment:
System: FreeBSD shiitake.ott.parse.com 6.2-RELEASE FreeBSD 6.2-RELEASE #1: Mon Jan 15 22:20:41 EST 2007 root@shiitake.ott.parse.com:/usr/obj/mnt/amd64_e1/static/source/freeBSD/src/6.2-RELEASE/amd64/sys/SHIITAKE amd64
>Description:
When the bktr driver detects a Hauppauge WinTV Go card, it gets the
id 0x79; there's no handler currently in the code but I have tested
the patch below and it works fine with my WinTV Go card.
>How-To-Repeat:
Put in a WinTV Go card with type 0x79 and note that the dmesg indicates "Warning - Unknown Hauppauge Tuner 0x79"
>Fix:
Here's the patch:
diff -ru ./bktr_card.c orig/bktr_card.c
--- ./bktr_card.c Tue Jan 16 17:09:17 2007
+++ orig/bktr_card.c Fri Jan 19 21:03:33 2007
@@ -1119,9 +1119,6 @@
case 0x2a:
bktr->msp_use_mono_source = 1;
select_tuner( bktr, PHILIPS_FR1216_PAL );
- goto checkDBX;
- case 0x79:
- select_tuner( bktr, PHILIPS_TDA6503_NTSC);
goto checkDBX;
default :
diff -ru ./bktr_tuner.c orig/bktr_tuner.c
--- ./bktr_tuner.c Tue Jan 16 17:07:48 2007
+++ orig/bktr_tuner.c Fri Jan 19 21:03:54 2007
@@ -299,16 +299,6 @@
0x00 },
{ 0x00, 0x00 }, /* band-switch crosspoints */
{ 0xa0, 0x90, 0x30, 0x8e } }, /* the band-switch values */
-
- /* PHILIPS_TDA6503_NTSC */
- { "Philips TDA6503 NTSC", /* the 'name' */
- TTYPE_NTSC, /* input type */
- { TSA552x_SCONTROL, /* control byte for Tuner PLL */
- TSA552x_SCONTROL,
- TSA552x_SCONTROL,
- 0x00 },
- { 0x00, 0x00 }, /* band-switch crosspoints */
- { 0x01, 0x02, 0x08, 0x00 } } /* the band-switch values */
};
diff -ru ./bktr_tuner.h orig/bktr_tuner.h
--- ./bktr_tuner.h Tue Jan 16 17:07:48 2007
+++ orig/bktr_tuner.h Fri Jan 19 21:04:06 2007
@@ -61,8 +61,7 @@
#define ALPS_TSBH1 13
#define TUNER_MT2032 14
#define LG_TPI8PSB12P_PAL 15
-#define PHILIPS_TDA6503_NTSC 16
-#define Bt848_MAX_TUNER 17
+#define Bt848_MAX_TUNER 16
/* experimental code for Automatic Frequency Control */
#define TUNER_AFC
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701200207.l0K27AVO002418>