From owner-freebsd-bugs@FreeBSD.ORG Sat Jan 20 02:50:13 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D0F3516A401 for ; Sat, 20 Jan 2007 02:50:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 9A2DE13C45B for ; Sat, 20 Jan 2007 02:50:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l0K2oDdR010538 for ; Sat, 20 Jan 2007 02:50:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l0K2oDtH010537; Sat, 20 Jan 2007 02:50:13 GMT (envelope-from gnats) Resent-Date: Sat, 20 Jan 2007 02:50:13 GMT Resent-Message-Id: <200701200250.l0K2oDtH010537@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Robert Krten Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E877716A407 for ; Sat, 20 Jan 2007 02:45:49 +0000 (UTC) (envelope-from root@parse.com) Received: from amd64.ott.parse.com (ottawa-hs-206-191-28-202.s-ip.magma.ca [206.191.28.202]) by mx1.freebsd.org (Postfix) with ESMTP id 7613413C442 for ; Sat, 20 Jan 2007 02:45:49 +0000 (UTC) (envelope-from root@parse.com) Received: from parse.com (localhost.ott.parse.com [127.0.0.1]) by parse.com (8.13.8/8.13.6) with ESMTP id l0K27AeJ002419 for ; Fri, 19 Jan 2007 21:07:10 -0500 (EST) (envelope-from root@parse.com) Received: (from root@localhost) by parse.com (8.13.8/8.13.6/Submit) id l0K27AVO002418; Fri, 19 Jan 2007 21:07:10 -0500 (EST) (envelope-from root) Message-Id: <200701200207.l0K27AVO002418@parse.com> Date: Fri, 19 Jan 2007 21:07:10 -0500 (EST) From: Robert Krten To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/108133: bktr driver doesn't recognize Hauppauge WinTV Go 0x79 type; patch enclosed X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Robert Krten List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jan 2007 02:50:13 -0000 >Number: 108133 >Category: kern >Synopsis: bktr driver doesn't recognize Hauppauge WinTV Go 0x79 type; patch enclosed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jan 20 02:50:13 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Robert Krten >Release: FreeBSD 6.2-RELEASE amd64 >Organization: PARSE Software Devices >Environment: System: FreeBSD shiitake.ott.parse.com 6.2-RELEASE FreeBSD 6.2-RELEASE #1: Mon Jan 15 22:20:41 EST 2007 root@shiitake.ott.parse.com:/usr/obj/mnt/amd64_e1/static/source/freeBSD/src/6.2-RELEASE/amd64/sys/SHIITAKE amd64 >Description: When the bktr driver detects a Hauppauge WinTV Go card, it gets the id 0x79; there's no handler currently in the code but I have tested the patch below and it works fine with my WinTV Go card. >How-To-Repeat: Put in a WinTV Go card with type 0x79 and note that the dmesg indicates "Warning - Unknown Hauppauge Tuner 0x79" >Fix: Here's the patch: diff -ru ./bktr_card.c orig/bktr_card.c --- ./bktr_card.c Tue Jan 16 17:09:17 2007 +++ orig/bktr_card.c Fri Jan 19 21:03:33 2007 @@ -1119,9 +1119,6 @@ case 0x2a: bktr->msp_use_mono_source = 1; select_tuner( bktr, PHILIPS_FR1216_PAL ); - goto checkDBX; - case 0x79: - select_tuner( bktr, PHILIPS_TDA6503_NTSC); goto checkDBX; default : diff -ru ./bktr_tuner.c orig/bktr_tuner.c --- ./bktr_tuner.c Tue Jan 16 17:07:48 2007 +++ orig/bktr_tuner.c Fri Jan 19 21:03:54 2007 @@ -299,16 +299,6 @@ 0x00 }, { 0x00, 0x00 }, /* band-switch crosspoints */ { 0xa0, 0x90, 0x30, 0x8e } }, /* the band-switch values */ - - /* PHILIPS_TDA6503_NTSC */ - { "Philips TDA6503 NTSC", /* the 'name' */ - TTYPE_NTSC, /* input type */ - { TSA552x_SCONTROL, /* control byte for Tuner PLL */ - TSA552x_SCONTROL, - TSA552x_SCONTROL, - 0x00 }, - { 0x00, 0x00 }, /* band-switch crosspoints */ - { 0x01, 0x02, 0x08, 0x00 } } /* the band-switch values */ }; diff -ru ./bktr_tuner.h orig/bktr_tuner.h --- ./bktr_tuner.h Tue Jan 16 17:07:48 2007 +++ orig/bktr_tuner.h Fri Jan 19 21:04:06 2007 @@ -61,8 +61,7 @@ #define ALPS_TSBH1 13 #define TUNER_MT2032 14 #define LG_TPI8PSB12P_PAL 15 -#define PHILIPS_TDA6503_NTSC 16 -#define Bt848_MAX_TUNER 17 +#define Bt848_MAX_TUNER 16 /* experimental code for Automatic Frequency Control */ #define TUNER_AFC >Release-Note: >Audit-Trail: >Unformatted: