From owner-freebsd-current@FreeBSD.ORG Mon Jun 29 21:11:42 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48E3C1065686 for ; Mon, 29 Jun 2009 21:11:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 19DD18FC0A for ; Mon, 29 Jun 2009 21:11:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id AEE1646B7E; Mon, 29 Jun 2009 17:11:41 -0400 (EDT) Received: from John-Baldwins-Macbook-Pro.local (localhost [IPv6:::1]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 602C98A088; Mon, 29 Jun 2009 17:11:40 -0400 (EDT) Message-ID: <4A492E0B.8070006@FreeBSD.org> Date: Mon, 29 Jun 2009 17:11:39 -0400 From: John Baldwin User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302) MIME-Version: 1.0 To: Steve Kargl References: <20090629184451.GA13281@troutmask.apl.washington.edu> <20090629194222.GA31358@troutmask.apl.washington.edu> <20090629201535.GA34777@troutmask.apl.washington.edu> In-Reply-To: <20090629201535.GA34777@troutmask.apl.washington.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 29 Jun 2009 17:11:40 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-3.3 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: freebsd-current@freebsd.org Subject: Re: Revision r193272 hoses kernel builds X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2009 21:11:42 -0000 Steve Kargl wrote: > On Mon, Jun 29, 2009 at 12:42:22PM -0700, Steve Kargl wrote: >> On Mon, Jun 29, 2009 at 11:44:51AM -0700, Steve Kargl wrote: >>> Am I missing something obvious? r193272 was committed on 20090601 >>> (over 28 days ago), and I haven't seen anyone else report this >>> build failure. >>> >> r193272 simply can't be correct. >> >> 1.168 ! jhb 125: static int nfs_clnt_tcp_soupcall(struct socket *so, void *arg, int waitflag); >> >> 1.116 ps 950: static void >> 951: nfs_clnt_tcp_soupcall(struct socket *so, void *arg, int waitflag) >> > > Making what appears to be the obvious fixes to > nfsclient/nfs_sockets.c leads to a failure in > /usr/src/sys/nfsserver/nfs_srvsock.c > > cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -march=opteron -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -Werror /usr/src/sys/nfsserver/nfs_srvsock.c > cc1: warnings being treated as errors > /usr/src/sys/nfsserver/nfs_srvsock.c: In function 'nfsrv_rcv': > /usr/src/sys/nfsserver/nfs_srvsock.c:530: warning: control reaches end of non-void function > *** Error code 1 I don't understand why this compiled fine. I tested the NFS client (my home dir was over NFS) with these changes as well. I don't know how you are getting a compile failure either. Both the nfsclient and nfsserver modules compile fine for me when built as modules. Hmm, are you using NFS_LEGACYRPC? That might explain it. The patch at http://www.FreeBSD.org/~jhb/patches/nfs_upcall.patch should fix the build, but NFS_LEGACYRPC is also slated to be removed for 8.0 I believe. -- John Baldwin