Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Jun 2019 10:13:54 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Cy Schubert <Cy.Schubert@cschubert.com>
Cc:        FreeBSD Current <freebsd-current@freebsd.org>, "Bjoern A. Zeeb" <bz@freebsd.org>,  "Julian H. Stacey" <jhs@berklix.com>, current@freebsd.org
Subject:   Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found
Message-ID:  <CANCZdfp_Ez8tOsy8C=qi3dgxnTyF0uc3AQjz4ksz1s_Sjr06%2BQ@mail.gmail.com>
In-Reply-To: <420F7EC2-F2AC-42ED-8F65-853E2870CAC7@cschubert.com>
References:  <201906170941.x5H9f3XR083239@fire.js.berklix.net> <20190617103724.GA2246@lonesome.com> <6CA19B53-FD17-42E9-89A6-5AD77E423912@FreeBSD.org> <420F7EC2-F2AC-42ED-8F65-853E2870CAC7@cschubert.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 17, 2019, 8:06 AM Cy Schubert <Cy.Schubert@cschubert.com> wrote:

> On June 17, 2019 3:55:45 AM PDT, "Bjoern A. Zeeb" <bz@FreeBSD.org> wrote:
> >On 17 Jun 2019, at 10:37, Mark Linimon wrote:
> >
> >> On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
> >>> svn_revision 348842
> >> [ ...]
> >>> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
> >>>       'opt_cam.h' file not found
> >>> #include "opt_cam.h"
> >>>          ^~~~~~~~~~~
> >>> 1 error generated.
> >>
> >> This is extremely unlikely to be r348842.  I would investigate
> >r349025
> >> instead.  (Committer Cc:ed.)
> >
> >Almost, more likely me.  I just had a look.  I am not exactly sure how
> >to reproduce this?
> >
> >/bz
> >_______________________________________________
> >freebsd-current@freebsd.org mailing list
> >https://lists.freebsd.org/mailman/listinfo/freebsd-current
> >To unsubscribe, send any mail to
> >"freebsd-current-unsubscribe@freebsd.org"
>
> Could this be a possible race? I had an unrelated build failure on one of
> my machines, all with the same src tree. Simply restarting the failed
> buildworld resolved it. All my other machines had no such failure.
>

The thing I fixed wasn't a race per se, but just s missing dependency for
the stand alone build case. I fixed exactly the bug reported, and the
report came from a rev w/o my change. I think it is just that simple.

Warner

-- 
> Pardon the typos and autocorrect, small keyboard in use.
> Cheers,
> Cy Schubert <Cy.Schubert@cschubert.com>
> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org
>
>         The need of the many outweighs the greed of the few.
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfp_Ez8tOsy8C=qi3dgxnTyF0uc3AQjz4ksz1s_Sjr06%2BQ>