From owner-freebsd-ports@FreeBSD.ORG  Sun Jul 18 22:38:31 2010
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 07A731065673;
	Sun, 18 Jul 2010 22:38:31 +0000 (UTC)
	(envelope-from linimon@lonesome.com)
Received: from mail.soaustin.net (lefty.soaustin.net [66.135.55.46])
	by mx1.freebsd.org (Postfix) with ESMTP id E04F38FC0C;
	Sun, 18 Jul 2010 22:38:30 +0000 (UTC)
Received: by mail.soaustin.net (Postfix, from userid 502)
	id 344448C078; Sun, 18 Jul 2010 17:38:30 -0500 (CDT)
Date: Sun, 18 Jul 2010 17:38:30 -0500
From: Mark Linimon <linimon@lonesome.com>
To: jhell <jhell@DataIX.net>
Message-ID: <20100718223830.GA10338@lonesome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.BSF.2.00.1007181813540.22190@pragry.qngnvk.ybpny>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: ports@FreeBSD.org, skv@FreeBSD.org
Subject: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Jul 2010 22:38:31 -0000

The intention of bsd.perl.mk was to eventually allow a bunch of code
to be pulled out of bsd.port.mk, and to have bsd.perl.mk only included
conditionally, on the theory that it will speed up INDEX building
somewhat.  (I have not tested for speedup).

The problem is that there are N ports that assume that the logic in
bsd.perl.mk is always available.  I've tried to convince people that
these are bugs, but OTOH if you leave out one of these definitions
such as USE_PERL5 or PERL_CONFIGURE, and _PERL_REFACTORING_COMPLETE
is defined, then INDEX breaks.

Every once in a while I try to put in patches to force N to zero, but
then I get stuck on wierd edge cases.  This is why the switch has not
been thrown.

Every time I try to work on this, "something happens" and it gets
shoved on the back-burner for several months.  This has been going
on for several years now ...

At this point it may be better to just do the following:

 - unconditionally include bsd.perl.mk and get rid of the code
   duplication that is in bsd.port.mk.

This would avoid the possibility of optimizing INDEX speed, but
instead, keep things robust.

What do people think?

mcl