From owner-p4-projects@FreeBSD.ORG  Tue Aug  1 17:42:37 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5CCC616A4E1; Tue,  1 Aug 2006 17:42:37 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2270A16A4DD;
	Tue,  1 Aug 2006 17:42:37 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CEA4D43D45;
	Tue,  1 Aug 2006 17:42:36 +0000 (GMT) (envelope-from sam@errno.com)
Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k71HgZ6B023579
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 1 Aug 2006 10:42:35 -0700 (PDT) (envelope-from sam@errno.com)
Message-ID: <44CF928B.7020102@errno.com>
Date: Tue, 01 Aug 2006 10:42:35 -0700
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 1.5.0.4 (X11/20060724)
MIME-Version: 1.0
To: Paolo Pisati <piso@freebsd.org>
References: <200608011725.k71HP4ol019342@repoman.freebsd.org>
In-Reply-To: <200608011725.k71HP4ol019342@repoman.freebsd.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 102954 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Aug 2006 17:42:37 -0000

Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=102954
> 
> Change 102954 by piso@piso_newluxor on 2006/08/01 17:24:16
> 
> 	Convert ath to use a filter+ithread handler:
> 	
> 	use a spinlock (inside softc) to guard against
> 	races when accessing sc_status or the interrupt registers,
> 	and axe all the taskqueue jobs from ath_intr().

I highly doubt this does the right thing and the spinlock is almost
certain to be the wrong thing to do here.  We should probably talk
privately about how to restructure ath to use your stuff but I expected
a very different approach.

	Sam