Date: Fri, 3 Jan 1997 15:53:58 +1100 From: Bruce Evans <bde@zeta.org.au> To: current@freebsd.org, jb@cimlogic.com.au Subject: Re: MOD_DECL in lkm.h Message-ID: <199701030453.PAA18846@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>Shouldn't the MOD_DECL macro in lkm.h also have: > >static int name ## _stat __P((struct lkm_table *lkmtp, int cmd)); \ > >so that the status function has a prototype defined before it is used? No, because it causes annoying warnings for modules that don't have a stat function when such modules are compiled with -Wunused. This reminds me that MOD_VFS() and MOD_SYSCALL() are missing declarations for the xxx_mod functions. Their interfaces only pass the stringified name of the function, so they can't declare things. VFS_SET() could easily declare the entry point, but it would be more consistent to declare everything in MOD_XXX(). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701030453.PAA18846>