Date: Wed, 4 Jan 2017 22:35:18 -0800 From: Ngie Cooper <yaneurabeya@gmail.com> To: Jilles Tjoelker <jilles@stack.nl> Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311233 - head/contrib/netbsd-tests/fs/tmpfs Message-ID: <340662A0-12F5-46A1-AEA0-CFC62732F91B@gmail.com> In-Reply-To: <20170104233650.GB17765@stack.nl> References: <201701040246.v042kaEh039041@repo.freebsd.org> <20170104233650.GB17765@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 4, 2017, at 15:36, Jilles Tjoelker <jilles@stack.nl> wrote: ... > It would be better to avoid naming the non-portable sun_len field if it > is just to make Coverity happy. I suggest initializing the structure > with designated initializers or memset(). >=20 > Apart from that, the value for sun_len is wrong; it should be the length > of the whole structure and not just the sun_path part. Fortunately, the > field is ignored by bind(), which uses the addrlen parameter instead. >=20 > On a more general note, refactoring tests without a way to verify they > have not been changed to always pass is risky :( Yeah... agreed. Unfortunately, the interest in reviewing tests is low.. some= people only care when they "break" :(.. In general, I try to test all of my changes carefully, but this item fell th= rough the cracks, due to my poor memory about how sockaddr_un is structured.= Thank you for the input jilles and jmallett! > --=20 > Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?340662A0-12F5-46A1-AEA0-CFC62732F91B>