Date: Tue, 5 Jun 2007 09:24:25 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: John-Mark Gurney <gurney_j@resnet.uoregon.edu> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, David Malone <dwmalone@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 tsc.c src/sys/amd64/isa clock.c src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_all.c src/sys/compat/opensolaris/kern opensolaris_kstat.c src/sys/dev/acpica acpi_timer.c src/sys/dev/bge if_bge.c src/sys/dev/sound clone.c ... Message-ID: <20070605092255.L76940@fledge.watson.org> In-Reply-To: <20070605050351.GJ4602@funkthat.com> References: <200706041825.l54IP8RD042273@repoman.freebsd.org> <20070605050351.GJ4602@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 4 Jun 2007, John-Mark Gurney wrote: > David Malone wrote this message on Mon, Jun 04, 2007 at 18:25 +0000: >> Log: >> Despite several examples in the kernel, the third argument of >> sysctl_handle_int is not sizeof the int type you want to export. >> The type must always be an int or an unsigned int. >> >> Remove the instances where a sizeof(variable) is passed to stop >> people accidently cut and pasting these examples. >> >> In a few places this was sysctl_handle_int was being used on 64 bit >> types, which would truncate the value to be exported. In these >> cases use sysctl_handle_quad to export them and change the format >> to Q so that sysctl(1) can still print them. > > Perhaps documenting SYSCTL_HANDLER_ARGS and the several standard handlers in > sysctl_add_oid(9) would be in order? Or even in sysctl(9). Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070605092255.L76940>