From owner-freebsd-stable@FreeBSD.ORG Sun Apr 10 19:41:26 2011 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2338E106566C; Sun, 10 Apr 2011 19:41:26 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id EF0248FC14; Sun, 10 Apr 2011 19:41:24 +0000 (UTC) Received: by fxm11 with SMTP id 11so4227735fxm.13 for ; Sun, 10 Apr 2011 12:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:x-comment-to :sender:date:in-reply-to:message-id:user-agent:mime-version :content-type; bh=Ixl81Yj4A8TaJXDVfsdnuBO1Sl8w9XV3Nl+OeomNtN8=; b=WdO11fTXV1+OeHL1RaAITFpUtv6GAbGjDY3acOJFtlH6UyvJ+9BjEFKChkRKpj5WW9 5X/bFl/Kj27ISCINBp4h37vKpsyzWQgks7TqDCQeI5nEIyWoH8Bxje3zH8tyJ+7IX/Zb 9i/othImTUS7S1DnuZ1xULf6dVZBkC3LJOiHQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:x-comment-to:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=ZkHUh5p3EG+K+6KRulpRYfsga+99EzZVA6f+VQJOmvpwRwOADjDU1KTU9AxOhDQN4E XRLFqcFDwjxKI3YrsrYsarP2hCqAQ2izY90f/DuEK49VXOWeI+/htAoacUOqSePSDNh1 NbnwnY/Tfc6hcGLrt6tcXgqJesLJcFoTsUSNA= Received: by 10.223.54.148 with SMTP id q20mr690538fag.84.1302464484073; Sun, 10 Apr 2011 12:41:24 -0700 (PDT) Received: from localhost ([95.69.172.154]) by mx.google.com with ESMTPS id t2sm1378397faa.23.2011.04.10.12.41.22 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 10 Apr 2011 12:41:23 -0700 (PDT) From: Mikolaj Golub To: Mikolaj Golub References: <20110326003348.GQ36706@equilibrium.bsdes.net> <20110401174354.GE1289@equilibrium.bsdes.net> <86pqp53cqe.fsf@kopusha.home.net> <20110402101750.GD1849@garage.freebsd.pl> <86zko7nsby.fsf@kopusha.home.net> X-Comment-To: Mikolaj Golub Sender: Mikolaj Golub Date: Sun, 10 Apr 2011 22:41:21 +0300 In-Reply-To: <86zko7nsby.fsf@kopusha.home.net> (Mikolaj Golub's message of "Sun, 03 Apr 2011 20:43:45 +0300") Message-ID: <8662qlx5b2.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Kostik Belousov , Victor Balada Diaz , stable@freebsd.org, Pawel Jakub Dawidek Subject: Re: geli(4) memory leak X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Apr 2011 19:41:26 -0000 On Sun, 03 Apr 2011 20:43:45 +0300 Mikolaj Golub wrote to Pawel Jakub Dawidek: MG> On Sat, 2 Apr 2011 12:17:50 +0200 Pawel Jakub Dawidek wrote: PJD>> On Sat, Apr 02, 2011 at 12:04:09AM +0300, Mikolaj Golub wrote: >>> For me your patch look correct. But the same issue is for read :-). Also, to >>> avoid the leak I think we can just do g_destroy_bio() before "all sectors" >>> check. See the attached patch (had some testing). PJD>> The patch looks good. Please commit. MG> Commited, thanks. In STABLE too. -- Mikolaj Golub