From owner-cvs-src@FreeBSD.ORG Sun Feb 1 00:00:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0410116A4CE for ; Sun, 1 Feb 2004 00:00:13 -0800 (PST) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id C567943D1D for ; Sun, 1 Feb 2004 00:00:08 -0800 (PST) (envelope-from silby@silby.com) Received: (qmail 81383 invoked from network); 1 Feb 2004 08:00:07 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay.pair.com with SMTP; 1 Feb 2004 08:00:07 -0000 X-pair-Authenticated: 209.68.2.70 Date: Sun, 1 Feb 2004 02:00:06 -0600 (CST) From: Mike Silbersack To: Mike Silbersack In-Reply-To: <200402010756.i117uiWm094818@repoman.freebsd.org> Message-ID: <20040201015908.B1877@odysseus.silby.com> References: <200402010756.i117uiWm094818@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_subr.c uipc_mbuf.cuipc_syscalls.c src/sys/sys uio.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2004 08:00:13 -0000 I tested this patch with apache2, thttpd (with alfred's sendfile patches) and ftpd; all seemed to work properly. Please throw whatever other sendfile using applications you have at it, it'd be best to find bugs sooner rather than later. Mike "Silby" Silbersack On Sat, 31 Jan 2004, Mike Silbersack wrote: > silby 2004/01/31 23:56:44 PST > > FreeBSD src repository > > Modified files: > sys/kern kern_subr.c uipc_mbuf.c uipc_syscalls.c > sys/sys uio.h > Log: > Rewrite sendfile's header support so that headers are now sent in the first > packet along with data, instead of in their own packet. When serving files > of size (packetsize - headersize) or smaller, this will result in one less > packet crossing the network. Quick testing with thttpd and http_load has > shown a noticeable performance improvement in this case (350 vs 330 fetches > per second.) > > Included in this commit are two support routines, iov_to_uio, and m_uiotombuf; > these routines are used by sendfile to construct the header mbuf chain that > will be linked to the rest of the data in the socket buffer. > > Revision Changes Path > 1.80 +42 -0 src/sys/kern/kern_subr.c > 1.125 +56 -0 src/sys/kern/uipc_mbuf.c > 1.171 +43 -12 src/sys/kern/uipc_syscalls.c > 1.31 +3 -0 src/sys/sys/uio.h >