Date: Wed, 13 Dec 2000 14:30:15 -0700 From: Warner Losh <imp@village.org> To: Mike Smith <msmith@FreeBSD.org> Cc: "Justin T. Gibbs" <gibbs@scsiguy.com>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files options src/sys/dev/pci pci_user.c eisa_pci.c pci.c pci_pci.c pcireg.h pcivar.h src/sys/pci pci_compat.c Message-ID: <200012132130.OAA41483@harmony.village.org> In-Reply-To: Your message of "Wed, 13 Dec 2000 13:05:16 PST." <200012132105.eBDL5G309996@mass.osd.bsdi.com> References: <200012132105.eBDL5G309996@mass.osd.bsdi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200012132105.eBDL5G309996@mass.osd.bsdi.com> Mike Smith writes: : However one of the objectives of this : work is to throw away most, if not all of the "cardbus bus" and just : attach PCI to the cardbus bridge. And me and everyone else that's working on cardbus code these days. I do *NOT* foresee cardbus going away entirely. It is a superset of the pci bus and we need to have it be a separate bus. We can share a whole lot of code, but there are some things that have to be different because cardbus is different than pci. Moving the differences into the bridge is not acceptible because we do not want to duplicate code in the N cardbus bridge types that we'll likely have to support in the futture. That's one big reason why we have a pccard bus rather than just making it a isa bus. Too many differences despite the fact that they are almost the same. : On the other hand, I'll note that so far all the technical review I've : recived has been criticism of my choice of 4-space indents over tabs. : I find this pretty miserable; the code works just as well (and is just as : readable) either way. How about focussing on the content? I think that he was objectnig to the style change within pci.c. There's no reason to do that. I've gone through and fixed it in my copy here. It is less readable than before because you have to switch gears too many times as you are bopping through the file. I like a lot of the direction that you are going Mike, but you really should be submitting this stuff for review since it is impacting things at the lowest levels of the system. The pci bus is a fairly imprtant part of the system and lots of people will be impacted by this work. I would have liked to have commented upon it before you commmitted the last set of changes or the cardbus changes. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012132130.OAA41483>