From owner-freebsd-bugs@freebsd.org  Thu Nov  2 15:08:46 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E255BE5C247
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Thu,  2 Nov 2017 15:08:46 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D11F681E5C
 for <freebsd-bugs@FreeBSD.org>; Thu,  2 Nov 2017 15:08:46 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vA2F8kB2067272
 for <freebsd-bugs@FreeBSD.org>; Thu, 2 Nov 2017 15:08:46 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 223382] PFKey SA Update Prevents UDP-Encap SA From Updated
 Correctly
Date: Thu, 02 Nov 2017 15:08:46 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.1-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: garrisoncreek@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-223382-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Nov 2017 15:08:47 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223382

            Bug ID: 223382
           Summary: PFKey SA Update Prevents UDP-Encap SA From Updated
                    Correctly
           Product: Base System
           Version: 11.1-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: garrisoncreek@gmail.com

When a UDP-encap SA is being updated with port change (e.g., MOBIKE update =
SA),
the updated SA is now an ESP SA.

The bug is in the function key_updateaddresses. Instead of setting up the r=
ight
NAT info on the new updated SA, it does it on the old SA (which is about to=
 be
freed). As a result, the updated SA has an empty NAT-T structure which means
ESP.

sys/netipsec/key.c

    newsav->natt =3D NULL;
    newsav->sah =3D sah;
    newsav->state =3D SADB_SASTATE_MATURE;
    error =3D key_setnatt(sav, mhp);
    if (error !=3D 0)
        goto fail;

When this is patched to:

    error =3D key_setnatt(newsav, mhp);

UDP-encap info (if any) is preserved.

NOTE: There are other SA address updates, it may be that key_setnatt(sav, m=
hp)
makes sense for them. I have not tested all scenarios.

--=20
You are receiving this mail because:
You are the assignee for the bug.=