Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Jun 2009 09:20:41 +0100 (BST)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Andre Oppermann <andre@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, Christoph Mallon <christoph.mallon@gmx.de>, src-committers@freebsd.org
Subject:   Re: svn commit: r194672 - in head/sys: kern netinet sys
Message-ID:  <alpine.BSF.2.00.0906290915510.69417@fledge.watson.org>
In-Reply-To: <4A486C20.2030307@freebsd.org>
References:  <200906222308.n5MN856I055711@svn.freebsd.org> <4A47CC93.5090908@gmx.de> <4A486C20.2030307@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Mon, 29 Jun 2009, Andre Oppermann wrote:

>> It seems either the third "if" is redundant (because the condition of first 
>> "if" implies the condition of the third) or one of the conditions is wrong. 
>> Also there should be spaces around the |.
>
> Thank you for the report.  I'm working on fixing and testing all the issues 
> that were raised in the perforce branch to be committed soon after review.

I'd really like to see soreceive_stream() grow support for control mbufs, if 
only by detecting controlp != NULL and calling soreceive_generic(), and having 
the mtouio routing properly detect and free them.  This would allow us to use 
soreceive_stream() with UNIX domain stream sockets, which are used by MySQL 
and see similar performance issues.

Robert N M Watson
Computer Laboratory
University of Cambridge



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0906290915510.69417>