From owner-cvs-src@FreeBSD.ORG Tue Jan 1 03:38:23 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D43316A418; Tue, 1 Jan 2008 03:38:23 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 2E95913C45D; Tue, 1 Jan 2008 03:38:23 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id m013bN16020791; Mon, 31 Dec 2007 20:37:23 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 31 Dec 2007 20:37:20 -0700 (MST) Message-Id: <20071231.203720.1306324107.imp@bsdimp.com> To: jhb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200712311219.08286.jhb@freebsd.org> References: <200712291507.lBTF7sTA069010@repoman.freebsd.org> <200712311219.08286.jhb@freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: rrs@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet sctp_bsd_addr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jan 2008 03:38:23 -0000 In message: <200712311219.08286.jhb@freebsd.org> John Baldwin writes: : On Saturday 29 December 2007 10:07:54 am Randall Stewart wrote: : > rrs 2007-12-29 15:07:54 UTC : > : > FreeBSD src repository : > : > Modified files: (Branch: RELENG_7_0) : > sys/netinet sctp_bsd_addr.c : > Log: : > - sctp-iterator should run at PI_NET priority ...not 0. : > Approved by: re@freebsd.org(gnn) : > : > Revision Changes Path : > 1.14.4.1 +1 -1 src/sys/netinet/sctp_bsd_addr.c : : The more correct fix though is to do a 'sched_prio()' at the start of the : thread's main loop to set the priority and then not adjust it via msleep(). : Kernel threads really should never pass a priority to msleep() but always '0' : (which means "don't change my priority"). Not PZERO? When should one use PZERO and when should one use a bare '0'? Can this information be added to the man page? Warner