From owner-freebsd-arch@FreeBSD.ORG Tue Jul 11 16:29:55 2006 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A087316A4E1; Tue, 11 Jul 2006 16:29:55 +0000 (UTC) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id E38F443D53; Tue, 11 Jul 2006 16:29:53 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k6BGTriJ028745; Tue, 11 Jul 2006 09:29:53 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k6BGTrna028744; Tue, 11 Jul 2006 09:29:53 -0700 Date: Tue, 11 Jul 2006 09:29:53 -0700 From: Brooks Davis To: Andrew Thompson Message-ID: <20060711162953.GC20418@odin.ac.hmc.edu> References: <44B15511.206@errno.com> <44B21551.5050002@freebsd.org> <20060710160441.GB31026@odin.ac.hmc.edu> <20060710202714.GC16054@heff.fud.org.nz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8X7/QrJGcKSMr1RN" Content-Disposition: inline In-Reply-To: <20060710202714.GC16054@heff.fud.org.nz> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new Cc: Andre Oppermann , freebsd-arch@freebsd.org Subject: Re: vlans and cloning X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2006 16:29:55 -0000 --8X7/QrJGcKSMr1RN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 11, 2006 at 08:27:14AM +1200, Andrew Thompson wrote: > On Mon, Jul 10, 2006 at 09:04:41AM -0700, Brooks Davis wrote: > > On Mon, Jul 10, 2006 at 10:52:33AM +0200, Andre Oppermann wrote: > > > Sam Leffler wrote: > > > >I committed the revised netif cloning api so you can now specify > > > >parameters when cloning. I also modified the vlan code to use this > > > >mechanism so doing something like: > > > > > > > >ifconfig vlan create vlan 1 vlandev em0 > > > > > > >=20 > > > /me wants to do: > > >=20 > > > "ifconfig em0.1 inet 192.168.2.2/24" > > >=20 > > > Even simpler. And yes, this works already but only if if_vlan.ko > > > was loaded before or compiled into the kernel. It doesn't do auto- > > > load. > >=20 > > Unless cause ifconfig to autoload all if_ modules when cloning fails, > > it's impossiable to support this without having if_vlan loaded. That > > said the current plan it to eliminate if_vlan and integrate vlan support > > directly into if_ethersubr.c to allow use to correctly handle the > > default vlan case among otherthings. >=20 > Is anyone working on this? The bridge code needs access to the vlan tag > to properly hash the address as each vlan is a seperate broadcast > domain, this would be much easier with vlan merged to if_ethersubr.c. I think it ended up with Robert's name on it at the last devsummit, but he's got a lot of higher priority stuff on his plate. It doesn't look like this change would be all that much work. The one thing that might be worth investigating is seeing if there's a sane way to make vlan tag parsing part of ether_input, but keep if_vlan.c around as a module for actual support of trunks so we get most of the architectural benefits of correctly treating vlan tags as part of the spec, but let embedded users who don't need trunks avoid the overhead. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --8X7/QrJGcKSMr1RN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFEs9H/XY6L6fI4GtQRAktzAJ0dQkVd5cYjmwHROYL6DO7J1c6McQCfaAig yWl2RPNHhmAo6ENqblD0jYk= =9E92 -----END PGP SIGNATURE----- --8X7/QrJGcKSMr1RN--