Date: Thu, 1 Jun 2017 09:58:38 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Brooks Davis <brooks@FreeBSD.org>, Ngie Cooper <ngie@FreeBSD.org>, "Marcel Moolenaar" <marcel@FreeBSD.org>, src-committers <src-committers@FreeBSD.org>, <svn-src-all@FreeBSD.org>, <svn-src-head@FreeBSD.org>, <sjg@juniper.net> Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Message-ID: <84744.1496336318@kaos.jnpr.net> In-Reply-To: <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > > These should not be stored uuencoded. It serves no purpose other > > than bloating the repo and causing spammy commit mails like this one > > where we got a huge tail of garbage output. The tests appear to contain generated filesystem images. eg. img-1x1-512-mbr.vmdk.gz.uu Is storing img-1x1-512-mbr.vmdk.gz any more palatable? One option would be to store a sha256 hash of the result. If the image generated by the test hashes to the correct value - you pass. Of course if the test fails, you are completely in the dark as to how/why. With the current arrangment, marcel at least has something he can examine to see where the output generation went wrong.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?84744.1496336318>