From owner-freebsd-git@freebsd.org Sat Jan 9 17:54:41 2021 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 27FEE4DE052 for ; Sat, 9 Jan 2021 17:54:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCnfn0WwJz3nmX for ; Sat, 9 Jan 2021 17:54:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x735.google.com with SMTP id z11so11364935qkj.7 for ; Sat, 09 Jan 2021 09:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7TfEu2zprZCGTRlQfLr05+AqolOj6JjS0wspg+Wj89Q=; b=RqmMtnF6bEmveIOCKyl16KjPX/QK4UDxoX/bwuXLq9bwEEVQspECJMdO8G62wh3erL T9mUuv7kdQycoeh8DOA1TlbRrKwprqGByTQstJWlwzIzuGTvpMwXUmwhwtKkCXYaHcIY pUA2fKXvtLJHQdrTue4wG7Sye48Q3oN7maQrxgfiasJ6CzCMmBx4y/q9gC5z10CUViXy xb1KDbG1Y/FizevuruTfyjjpRBCJ2xlr5KjEMCWeNwz2HbevX8IOv/tGOuCsJYrk2XoS WVRcOHZFSTHG9Ti/QoVgEQIi9a0PxWhloAeXCjQimIhSsZ1NH8V29UrXHgY1HlLOnbE7 UGhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7TfEu2zprZCGTRlQfLr05+AqolOj6JjS0wspg+Wj89Q=; b=fPYyygBm1bFWiqF1ytKWGDzgbHHd7sIAZp9WCTW3qOZM2xjZjfvvpqc/Y0S7/uQZll dpsgwB+1Pwb6I/aKFUaKQP1QzSaG2Y+kbKVAfOUijdFY6AxQtOom0Q6rGv7GppzJs5ch 5pDyt/SNmAqTOUDZHIaqUauoFx5LUqaEtEQj6n5SiDtK71JPDW15uevYGxDgxx7F/kgy vLb3uLu8Cg85RHFeBm1P5NHDE0FBjQXtRiHM9MBbTj6uh6hAa/Dxwf7oxYA6MlgAIKc9 1BdMv3a29fF3pmnDsUtKLYogCJ/B5UNc7X6SvTHXCGn2uGoagT1GKUqHk5GqDiSlGR9D DFLQ== X-Gm-Message-State: AOAM532sF/jj1nMNr5yMx3888xKHg1OnVxSIWdi2E4YUX6dqofsEW1aw G/xO561WXhgSf1Ga3jFxelsFaibvVkBAklmFJM9k9g== X-Google-Smtp-Source: ABdhPJyXiuompcgzq/5fVQi/d8RegrfYk33kX19WQZOiw9TkAtfSRUDEMKPehRF59U+S6L/sk1Ykp4yr+XHpwlZ7fH0= X-Received: by 2002:a37:a614:: with SMTP id p20mr9277493qke.359.1610214879943; Sat, 09 Jan 2021 09:54:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Sat, 9 Jan 2021 10:54:29 -0700 Message-ID: Subject: Re: Patch Attribution To: Kyle Evans Cc: freebsd-git X-Rspamd-Queue-Id: 4DCnfn0WwJz3nmX X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2021 17:54:41 -0000 On Sat, Jan 9, 2021 at 10:52 AM Kyle Evans wrote: > Hello! > > I haven't (that I recall) seen any particular guidance one way or the > other, but what's the general feeling on "Submitted by" for patches > that come in via Bugzilla without commit metadata vs. committing > locally with --author="Name "? > > I did this with d36b5db and didn't receive any complaints, but I'm > curious if we should be more actively promoting setting the author > correctly whether the patch came in with it or not. I noted that > Warner's meta doc[0] lists "Submitted-by" which is where my > uncertainty comes from. > My document should be updated. I think what you did is fine, and we should document it as best practice. Warner