Date: Tue, 14 Nov 1995 18:47:06 +1100 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, davidg@Root.COM Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/nfs nfs_syscalls.c Message-ID: <199511140747.SAA02115@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>>>> Ifdefed duplicated decentralized declarations of args structs. It's >>... >>> Now that the definitions are in sysproto.h, I'd like to see them removed >>>from the .c files. >> >>I'm not sure if they should be removed as far as that. Do you think we >>should remove the pseudo-declarations from all vnode op functions too? >>Such declarations are useful iff they are correct. For examples of >>possibly harmful incorrect ones, see almost any readdir(): > The vnode op functions are auto-generated and not really part of the source >tree. I see syscalls as being different since the delarations are now in a >standard, centralized place. Only the VOP* stubs are automatically generated. Compare rename() with ufs_rename(). We can retire when ufs_rename() can be automatically generated :-). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199511140747.SAA02115>