From owner-freebsd-current@freebsd.org Tue May 10 06:24:37 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC8DAB352DE for ; Tue, 10 May 2016 06:24:37 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 98B62177D for ; Tue, 10 May 2016 06:24:37 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 981EAB352DD; Tue, 10 May 2016 06:24:37 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 97CDAB352DC for ; Tue, 10 May 2016 06:24:37 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 89068177C; Tue, 10 May 2016 06:24:37 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by freefall.freebsd.org (Postfix) with ESMTP id 4B1E01100; Tue, 10 May 2016 06:24:37 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Tue, 10 May 2016 06:24:36 +0000 From: Glen Barber To: "O. Hartmann" Cc: current@FreeBSD.org Subject: Re: HEADS-UP: installworld on r299292 through r299317 will replace master.passwd, passwd, and group files Message-ID: <20160510062436.GB47527@FreeBSD.org> References: <20160510055341.GA47527@FreeBSD.org> <20160510081844.54f1cb28@freyja.zeit4.iv.bundesimmobilien.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PAKmkkBo0+rTwAqJ" Content-Disposition: inline In-Reply-To: <20160510081844.54f1cb28@freyja.zeit4.iv.bundesimmobilien.de> X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2016 06:24:37 -0000 --PAKmkkBo0+rTwAqJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 10, 2016 at 08:18:44AM +0200, O. Hartmann wrote: > On Tue, 10 May 2016 05:53:41 +0000 > Glen Barber wrote: >=20 > > Thanks to O. Hartmann promptly reporting this, it was discovered that > > 'installworld' on revisions r299292-r299317 will silently replace > > /etc/passwd, /etc/master.passwd, and /etc/group with the defaults. It > > is possible there are other files affected. One file I can think of > > off-hand is /etc/mail/aliases, but in my development system, did not > > have local changes to this, so cannot 100% confirm. > >=20 > > Please avoid this range of revisions. > >=20 > > I am very sorry this went unnoticed before this change was committed. > >=20 >=20 > Great! >=20 > It is not only master.passwd, it is also group and several other config f= iles, > I suspect it is the whole bunch of files located in /etc/ getting reset to > their initial file values. >=20 > My OpenLDAP environment isn't working anymore due to /etc/pam.d reset. X11 > doesn't start anymore due to reset of /etc/ttys. also, sysctl.conf has be= en > reset. >=20 > I haven't figured out so far how far this goes. Lucky for those having > recent /etc/ backups. A pity FreeBSD doens't backup this by default. >=20 The change (incorrectly) invoked the 'distribution' target, so anything that gets "touched" by that will likely be affected. You are correct that we should have an additional failsafe for this kind of thing, not just a subset of files arbitrarily placed in /var/backups via a periodic(8) script. Glen --PAKmkkBo0+rTwAqJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXMX6kAAoJEAMUWKVHj+KTWoQP/1ledZvADNDlT8xNCCEHBqau gMyjKWJzwecogXnhcv/qqeryuxbqHwUJlrk9VDuKHJeXnTN7YM9SzvZRNSVrOKlM facfKfPM4rkY9SsttkERCQ69dqwQclgocAQB0SGVzJjMTf7h+qtfpInEO21AuUp3 CZQrhlEdq/TRx3oi5wx6n4RCHzNWhvv1O1N6ln1itISXPK6hsbd74ptP1cGsUg2J kuLlhFWw9MUutMBb6HzczkwPZIjQEiDSK2e1jO40RlMw70hl3Tf5cWfRoF4Fae6/ 0kGNgH12sc4H7nDET/LOOdEcKRstXTSyRBCGO7Z5n80v5RCLoc3h4c7nUOoZauQc P6ntbQybhJegd+id/bgSbc95EiIP/QiahgW30QLf5SBWfJemY7+1vCKh8JwUVCoz kJUIH7Pgon0f+AxedTjw8+WEVETsUKeJ7WikeXS18EfxLo0vE11HrK/JHxFMoUq9 qFKSYf2jVzPbj/RFDYvEFr2+i9CK+mQi3MQD3AfSN6TV0jGHqdcOv7RLpz1HwRE/ dB7F79Lvv8gb+eQ6xEk+XlkA/2iXFxEGL3x2AXvBOTe/bHg/q0MM7+tAcItW5H3c MShDN1LE+euj57ua4fTjHV/Ms9kFUbSctEbyKzM4s7E7S7ff/Dp3YGmMW1QdirmT 6X4RNLP6sxdeEhENlOjk =rxJE -----END PGP SIGNATURE----- --PAKmkkBo0+rTwAqJ--