Date: Sat, 27 Apr 2002 17:08:36 -0700 From: Peter Wemm <peter@wemm.org> To: Maxime Henrion <mux@freebsd.org> Cc: current@freebsd.org Subject: Re: Recent commit to sys/kern/kern_environment.c broke reading tunables Message-ID: <20020428000836.0808E3810@overcee.wemm.org> In-Reply-To: <20020428000146.GB63621@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxime Henrion wrote: > Peter Wemm wrote: > > This turned out to be part of the problem. I committed your patch and > > another followup that got the rest of it. The outstanding problems were: > > 1) checkmethod caused use_kenv to be set only once and the next time it > > was called, use_kenv would stay at zero and static hints only got used. > > 2) the termination of the kenvp[] loop could do a null deref. > > > > Anyway, I've committed both your and my changes, it should be working now. > > If anybody else sees problems still, please yell. > > Thanks for taking the time to fix this. I was unavailable the whole day > and tried to see what was causing the problem quickly this morning, but > I expected this to not be sufficient, and it indeed wasn't :-). I think a lot of this was hidden on i386 because of the acpi/pnpbios support, and the fact that a bunch of devices are hard coded in (clock etc). Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020428000836.0808E3810>