From owner-freebsd-arch Sun Aug 5 9:24:27 2001 Delivered-To: freebsd-arch@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 1FD7637B403 for ; Sun, 5 Aug 2001 09:24:15 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: by bazooka.unixfreak.org (Postfix, from userid 1000) id 225003E35; Sun, 5 Aug 2001 09:24:14 -0700 (PDT) Received: from bazooka.unixfreak.org (localhost [127.0.0.1]) by bazooka.unixfreak.org (Postfix) with ESMTP id 173C83C12D; Sun, 5 Aug 2001 09:24:14 -0700 (PDT) To: Brian Somers Cc: arch@FreeBSD.ORG, brian@freebsd-services.com Subject: Re: Library routine to load a kld if it already isn't In-Reply-To: <200108051617.f75GHGu44097@hak.lan.Awfulhak.org>; from brian@Awfulhak.org on "Sun, 05 Aug 2001 17:17:16 +0100" Date: Sun, 05 Aug 2001 09:24:09 -0700 From: Dima Dorfman Message-Id: <20010805162414.225003E35@bazooka.unixfreak.org> Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Brian Somers writes: > > Brian Somers writes: > > > > Programs that control a certain driver or set of drivers (e.g., > > > > ifconfig, ccdconfig, mdconfig) attempt to load the module they'll be > > > > working with if it isn't already present. They do it in different > > > > ways, and the most correct way (i.e., the one that handles the most > > > > cases properly) is liable to change if the kld subsystem ever changes. > > > > I propose to add a library routine, kldmaybeload(3), that will check > > > > if a certain module is present in the kernel, and load it if it isn't. > > > > This will cut down on duplicated code, and may save some headaches > > > > later if the kld interface changes. > > > > > > > > Sharball of the implementation and man page is attached (extract into > > > > src/lib/libc/gen). Comments? Suggestions? > > > > > > This is normally done with: > > > > > > if (modfind("module") == -1 && ID0kldload("module") == -1) > > > errx(); > > > > > > I don't think it's a good idea to change this. > > > > Only it's wrong in some cases. Some modules will have a bus attached > > to their name, such as "pci/if_fxp", and modfind() won't find them > > unless you give the full name. If it were just the simpler cases as > > above, I probably wouldn't propose this; it's them more complex cases > > where this would help. > > Hmm, what's the reasoning behind this. Is one of these an miibus > based fxp and the other not ? If so, is the plan to deprecate one ? > I find this bizarre - there's no trace of anything about this in > NOTES or fxp(4). This isn't fxp-specific, I just used fxp as an example. Do a "kldstat -v" and you'll see a lot of other drivers with bus names in front. Here's a small exerpt: 78 nexus/npx 79 isa/npxisa 80 nexus/pcib 81 pci/hostb 82 isa/pcibus_pnp 83 atkbdc/atkbd > Nonetheless, shouldn't modfind() be made capable of doing it's job > properly (finding "pci/if_fxp" if that's what's really required) ? Well, no, because the module name really is "pci/if_fxp". The reason you can use kldload("if_fxp"); is because the filename is if_fxp.ko. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message