From owner-cvs-src@FreeBSD.ORG  Fri Jun 15 00:19:19 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2877216A41F;
	Fri, 15 Jun 2007 00:19:19 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 139E213C44B;
	Fri, 15 Jun 2007 00:19:19 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196])
	by elvis.mu.org (Postfix) with ESMTP id 575471A3C1A;
	Thu, 14 Jun 2007 17:18:49 -0700 (PDT)
Received: from rot13.obsecurity.org (rot13.obsecurity.org [192.168.1.5])
	by obsecurity.dyndns.org (Postfix) with ESMTP id 346EE5125A;
	Thu, 14 Jun 2007 20:19:18 -0400 (EDT)
Received: by rot13.obsecurity.org (Postfix, from userid 1001)
	id CD4FFBEC4; Thu, 14 Jun 2007 20:19:17 -0400 (EDT)
Date: Thu, 14 Jun 2007 20:19:17 -0400
From: Kris Kennaway <kris@obsecurity.org>
To: Randall Stewart <rrs@FreeBSD.org>
Message-ID: <20070615001917.GA94743@rot13.obsecurity.org>
References: <200706142259.l5EMx4aW053356@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200706142259.l5EMx4aW053356@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet sctp.h sctp_asconf.c sctp_asconf.h
	sctp_bsd_addr.c sctp_constants.h sctp_indata.c sctp_input.c
	sctp_lock_bsd.h sctp_os_bsd.h sctp_output.c sctp_pcb.c
	sctp_pcb.h sctp_peeloff.c sctp_sysctl.c sctp_sysctl.h
	sctp_timer.c sctp_uio.h ...
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2007 00:19:19 -0000

On Thu, Jun 14, 2007 at 10:59:04PM +0000, Randall Stewart wrote:
> rrs         2007-06-14 22:59:04 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/netinet          sctp.h sctp_asconf.c sctp_asconf.h 
>                          sctp_bsd_addr.c sctp_constants.h 
>                          sctp_indata.c sctp_input.c 
>                          sctp_lock_bsd.h sctp_os_bsd.h 
>                          sctp_output.c sctp_pcb.c sctp_pcb.h 
>                          sctp_peeloff.c sctp_sysctl.c 
>                          sctp_sysctl.h sctp_timer.c sctp_uio.h 
>                          sctp_usrreq.c sctputil.c sctputil.h 
>     sys/netinet6         sctp6_usrreq.c 
>     sys/conf             options 
>   Log:
>   - Fix so ifn's are properly deleted when the ref count goes to 0.
>   - Fix so VRF's will clean themselves up when no references are around.
>   - Allow sctp_ifa to be passed into inpcb_bind, addr_mgmt_ep_sa to bypass
>     normal validation checks.
>   - turn auto-asconf off for subset bound sockets
>   - Moves all logging to use KTR. This gets rid of most
>     of the logging #ifdef's with a few exceptions reducing
>     the number of config options for SCTP.

| +#ifndef SCTP_SUBSYS_KTR
| +#define SCTP_SUBSYS_KTR KTR_GEN
| +#endif

Brief silence after previous disapproval doesn't equal approval ;-)

What was wrong with the method I suggested, namely using KTR_SUBSYS if
a SCTP_TRACE option is included in the kernel?  That is the intended
way that events local to a particular subsystem should be handled.

Kris