From owner-freebsd-current@freebsd.org Fri Feb 5 02:03:04 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 908B0A9C687 for ; Fri, 5 Feb 2016 02:03:04 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com [IPv6:2607:f8b0:400e:c00::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 69AB4D0; Fri, 5 Feb 2016 02:03:04 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pf0-x235.google.com with SMTP id o185so59736296pfb.1; Thu, 04 Feb 2016 18:03:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=BMBg9I/uIO9rIjYRPBxRHmcXCudMImJYoG1KJAUfGnU=; b=CB1lHfHlfVInG99UghhpWIhyFMkcUsFYwYxOdZ5Rcc1C38ZNPMM9DqqTwuuh5+blJt xeqnLdbRJVDHRmaLsSUFJv+Ad+jCgOIAEOJVGRCk7oFOHdj4+mOlL1Wan+t+WM+so+RZ UCEOEDkxXde8Afdj6Ldoi9mLzOxyrHiGeAv82abpQUX/Al/Cf7wNzlznu42irc1w8dej fo+lMR/OVTgRr8u/4uka+0idSjrCBPLS0MFtyJoXytpf1VAh+lNCPAw31o1VbzcfECfH G2oqBz6FeKIiuz13JrFNqpO8pVclnm3aKVnNn+PYW2TBnf4mFI+zNIt/Zh2kqkuwO3l3 E72Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=BMBg9I/uIO9rIjYRPBxRHmcXCudMImJYoG1KJAUfGnU=; b=dxmbVNk+EZKrrzDixQ87PwzJSDcebk4mfKb4VlzTqcvS5myhHOI2vEt04w8ECaJbcy HsSOyUWwe3qmBzfA056ephmCj1053mcC1cMkboSQ2z6FESVF3GF06brJUEHglPN3QiJ0 kP17gnE/ZPw0dD2kjga768IDQvJAPUzw45CBS8b4a3RIwxAxJfHo7CbuBgaw0SHnx0GR 9hVWNYtdpmHnt5Eib78zUsA+FxrcVMj5QkIv6aI/OCmnG2Y0/IOQewYm7LxiEuh787Pe oOdEFG2xCSs3HlzxaafTuhUDVEDAE88DfW71/35y6RO2l5asCXwQYF8fOBDpU2f4O/q9 oVQw== X-Gm-Message-State: AG10YOSfZ1SvPMSCxyayJExeJ3jmw8QX3aSH+ykAeIsBw5bhYs72xbrAsPNQcw6yD7ZtUA== X-Received: by 10.98.13.154 with SMTP id 26mr1667278pfn.164.1454637784012; Thu, 04 Feb 2016 18:03:04 -0800 (PST) Received: from wkstn-mjohnston.west.isilon.com (c-67-182-131-225.hsd1.wa.comcast.net. [67.182.131.225]) by smtp.gmail.com with ESMTPSA id t29sm20076230pfi.8.2016.02.04.18.03.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Feb 2016 18:03:03 -0800 (PST) Sender: Mark Johnston Date: Thu, 4 Feb 2016 18:05:43 -0800 From: Mark Johnston To: Eric van Gyzen Cc: FreeBSD Current Subject: Re: Kernel memory leak with x11/nvidia-driver Message-ID: <20160205020543.GA1661@wkstn-mjohnston.west.isilon.com> References: <56B230CB.3050600@FreeBSD.org> <56B3E0B4.4090603@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B3E0B4.4090603@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2016 02:03:04 -0000 On Thu, Feb 04, 2016 at 05:37:24PM -0600, Eric van Gyzen wrote: > On 02/ 3/16 10:54 AM, Eric van Gyzen wrote: > > I just set up a new desktop running head with x11/nvidia-driver. I've > > discovered a memory leak where pages disappear from the queues, never to > > return. Specifically, the total of > > v_active_count > > v_inactive_count > > v_wire_count > > v_cache_count > > v_free_count > > drops, eventually becoming /much/ less than v_page_count. After leaving > > xscreensaver running overnight, cycling the saver every 10 minutes, the > > system was unusable, because it only had a few MB of memory. (It has 8 > > GB physical.) > > In case anyone is curious, /usr/local/bin/xscreensaver-hacks/glmatrix > triggers a fairly fast leak--around 600 pages per second. I'm able to repro this on my workstation. With DTrace I can see that glmatrix is allocating pages for an SG object at roughly the rate they're being leaked. I took a look at r292373 (based on the history of sg_pager.c) and noticed a vm_page_free() call was lost when sg_pager_getpages() was simplified. The patch below seems to do the trick for me. Could you give it a try and confirm that it fixes the problem? I run current+nvidia-driver on multiple workstations but hadn't observed a leak until now, so maybe there's something additional going on in your case. Then again, I just use i3lock. :) diff --git a/sys/vm/sg_pager.c b/sys/vm/sg_pager.c index 84bfa49..2cccb7ea 100644 --- a/sys/vm/sg_pager.c +++ b/sys/vm/sg_pager.c @@ -189,6 +189,9 @@ sg_pager_getpages(vm_object_t object, vm_page_t *m, int count, int *rbehind, VM_OBJECT_WLOCK(object); TAILQ_INSERT_TAIL(&object->un_pager.sgp.sgp_pglist, page, plinks.q); vm_page_replace_checked(page, object, offset, m[0]); + vm_page_lock(m[0]); + vm_page_free(m[0]); + vm_page_unlock(m[0]); m[0] = page; page->valid = VM_PAGE_BITS_ALL;