From owner-freebsd-bugs@FreeBSD.ORG Sun Apr 6 16:00:36 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC1F337B401 for ; Sun, 6 Apr 2003 16:00:36 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E050543FBD for ; Sun, 6 Apr 2003 16:00:35 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h36N0ZUp038769 for ; Sun, 6 Apr 2003 16:00:35 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h36N0ZJl038768; Sun, 6 Apr 2003 16:00:35 -0700 (PDT) Resent-Date: Sun, 6 Apr 2003 16:00:35 -0700 (PDT) Resent-Message-Id: <200304062300.h36N0ZJl038768@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Edwin Groothuis Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57A7037B401 for ; Sun, 6 Apr 2003 15:53:37 -0700 (PDT) Received: from topaz.ad1810.com (topaz.ad1810.com [212.204.230.141]) by mx1.FreeBSD.org (Postfix) with ESMTP id C8D6A43F93 for ; Sun, 6 Apr 2003 15:53:36 -0700 (PDT) (envelope-from edwin@mavetju.org) Received: from k7.mavetju (topaz.ad1810.com [212.204.230.141]) by topaz.ad1810.com (Postfix) with ESMTP id 07DE92B99D for ; Mon, 7 Apr 2003 00:53:34 +0200 (CEST) Received: by k7.mavetju (Postfix, from userid 1001) id 6EE5C6A712B; Mon, 7 Apr 2003 08:53:31 +1000 (EST) Message-Id: <20030406225331.6EE5C6A712B@k7.mavetju> Date: Mon, 7 Apr 2003 08:53:31 +1000 (EST) From: Edwin Groothuis To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/50656: /bin/cp - wrong error on copying of multiple files X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Edwin Groothuis List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Apr 2003 23:00:37 -0000 >Number: 50656 >Category: bin >Synopsis: /bin/cp - wrong error on copying of multiple files >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Apr 06 16:00:33 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Edwin Groothuis >Release: FreeBSD 4.7-RELEASE i386 >Organization: - >Environment: System: FreeBSD k7.mavetju 4.7-RELEASE FreeBSD 4.7-RELEASE #0: Mon Mar 3 09:15:38 EST 2003 edwin@k7.mavetju:/usr/src/sys/compile/k7 i386 FreeBSD ref5.freebsd.org 5.0-CURRENT FreeBSD 5.0-CURRENT #65: Sun Mar 30 09:00:38 PST 2003 root@ref5.freebsd.org:/usr/src/sys/i386/compile/REF5 i386 >Description: If I copy multiple files to a directory which doesn't exist, it gives me the usage screen instead of a message saying "cp: a: No such directory". >How-To-Repeat: create directory a, don't create files b and c: [~] edwin@k7>/bin/cp c b a cp: b: No such file or directory cp: c: No such file or directory [~] edwin@k7>/bin/cp a b c usage: cp [-R [-H | -L | -P]] [-f | -i | -n] [-pv] src target cp [-R [-H | -L | -P]] [-f | -i | -n] [-pv] src1 ... srcN directory >Fix: In cp.c, around line 213 (for the 4.7 sources) something like: if (r == -1 || !S_ISDIR(to_stat.st_mode)) { /* * Case (1). Target is not a directory. */ if (argc > 1) { - usage(); + warnx(1,"Target is not a directory"); exit(1); } /* >Release-Note: >Audit-Trail: >Unformatted: