Date: Tue, 26 Jun 2012 19:56:40 GMT From: CyberRax <CyberRax@Yahoo.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/169464: security/openssl Makefile has faulty descriptions Message-ID: <201206261956.q5QJueHA042606@red.freebsd.org> Resent-Message-ID: <201206262000.q5QK0Nl4031544@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169464 >Category: ports >Synopsis: security/openssl Makefile has faulty descriptions >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jun 26 20:00:22 UTC 2012 >Closed-Date: >Last-Modified: >Originator: CyberRax >Release: i386 9.0-stable >Organization: >Environment: FreeBSD marvin 9.0-STABLE FreeBSD 9.0-STABLE #0: Mon Jun 18 22:59:12 EEST 2012 root@marvin:/usr/obj/usr/src/sys/MARVIN i386 >Description: The description in OpenSSL's Makefile for "386" option: - "Use optimized assembler for x86" OpenSSL's INSTALL file however gives a different description: - "Use the 80386 instruction set only (the default x86 code is more efficient, but requires at least a 486) [...]" Also for the "no-sse2" option the INSTALL text specifies the following: - "Both '386' and 'no-asm' options above imply 'no-sse2'" So while the "386" setting is disabled by default it does suggest that turning it ON in x86 hardware would result in better performance, while it's actually the opposite on anything newer than a i386. It also disables SSE2 support (which is activated by default). Also for atleast 2 updates the Makefiles names the RC5 cipher "C5 chipher". My native tongue ain't English, so perhaps "chipher" (with an 'h') is indeed correct, but the name of the algorithm most definitly isn't. >How-To-Repeat: Take a look at /usr/ports/security/openssl/Makefile >Fix: See attached patch Patch attached with submission follows: --- Makefile 2012-06-26 06:41:01.000000000 +0300 +++ Makefile 2012-06-26 21:08:33.000000000 +0300 @@ -28,7 +28,7 @@ OPTIONS_DEFINE= SHARED THREADS I386 SSE2 ASM PADLOCK ZLIB SCTP MD2 RC5 RFC3779 GMP OPTIONS_DEFAULT=SHARED THREADS SSE2 ASM ZLIB SCTP MD2 NO_OPTIONS_SORT=yes -I386_DESC?= Use optimized assembler for x86 +I386_DESC?= Optimize for i386 (instead of i486+) SSE2_DESC?= Enable runtime SSE2 detection ASM_DESC?= Enable optimized Assembler code PADLOCK_DESC?= Enable VIA Padlock support @@ -36,7 +36,7 @@ ZLIB_DESC?= Enable zlib compression support SCTP_DESC?= Enable SCTP protocol support MD2_DESC?= Enable MD2 hash (obsolete) -RC5_DESC?= Enable C5 chipher (patented) +RC5_DESC?= Enable RC5 cipher (patented) RFC3779_DESC?= Enable RFC3779 support GMP_DESC?= Enable gmp support (LGPLv3) >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206261956.q5QJueHA042606>