Date: Thu, 28 Apr 2016 03:30:38 +0000 From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D6137: tcp/lro: Refactor the free/active list operation. Message-ID: <differential-rev-PHID-DREV-mroevi6nzobvlsf24xxb-req@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
--b1_9224c4cda1a9d45d20fecae5fbdb2c16 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, gallatin, rrs, adrian, delphij, glebius, hselasky, np, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added a subscriber: freebsd-net-list. Herald added a reviewer: transport. REVISION SUMMARY Ease more work concerning active list, e.g. hash table etc. REVISION DETAIL https://reviews.freebsd.org/D6137 AFFECTED FILES sys/netinet/tcp_lro.c EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, transport, gallatin, rrs, adrian, delphij, glebius, hselasky, np, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com Cc: freebsd-net-list --b1_9224c4cda1a9d45d20fecae5fbdb2c16 Content-Type: text/x-patch; charset=utf-8; name="D6137.15684.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D6137.15684.patch" ZGlmZiAtLWdpdCBhL3N5cy9uZXRpbmV0L3RjcF9scm8uYyBiL3N5cy9uZXRpbmV0L3RjcF9scm8u YwotLS0gYS9zeXMvbmV0aW5ldC90Y3BfbHJvLmMKKysrIGIvc3lzL25ldGluZXQvdGNwX2xyby5j CkBAIC02OSw2ICs2OSwzOSBAQAogCiBzdGF0aWMgdm9pZAl0Y3BfbHJvX3J4X2RvbmUoc3RydWN0 IGxyb19jdHJsICpsYyk7CiAKK3N0YXRpYyBfX2lubGluZSB2b2lkCit0Y3BfbHJvX2FjdGl2ZV9p bnNlcnQoc3RydWN0IGxyb19jdHJsICpsYywgc3RydWN0IGxyb19lbnRyeSAqbGUpCit7CisKKwlM SVNUX0lOU0VSVF9IRUFEKCZsYy0+bHJvX2FjdGl2ZSwgbGUsIG5leHQpOworfQorCitzdGF0aWMg X19pbmxpbmUgdm9pZAordGNwX2xyb19hY3RpdmVfcmVtb3ZlKHN0cnVjdCBscm9fZW50cnkgKmxl KQoreworCisJTElTVF9SRU1PVkUobGUsIG5leHQpOworfQorCitzdGF0aWMgX19pbmxpbmUgc3Ry dWN0IGxyb19lbnRyeSAqCit0Y3BfbHJvX2VudHJ5X2dldChzdHJ1Y3QgbHJvX2N0cmwgKmxjKQor eworCXN0cnVjdCBscm9fZW50cnkgKmxlOworCisJbGUgPSBMSVNUX0ZJUlNUKCZsYy0+bHJvX2Zy ZWUpOworCWlmIChsZSA9PSBOVUxMKQorCQlyZXR1cm4gKE5VTEwpOworCUxJU1RfUkVNT1ZFKGxl LCBuZXh0KTsKKwlyZXR1cm4gKGxlKTsKK30KKworc3RhdGljIF9faW5saW5lIHZvaWQKK3RjcF9s cm9fZW50cnlfcHV0KHN0cnVjdCBscm9fY3RybCAqbGMsIHN0cnVjdCBscm9fZW50cnkgKmxlKQor eworCisJTElTVF9JTlNFUlRfSEVBRCgmbGMtPmxyb19mcmVlLCBsZSwgbmV4dCk7Cit9CisKIGlu dAogdGNwX2xyb19pbml0KHN0cnVjdCBscm9fY3RybCAqbGMpCiB7CkBAIC0xMjksNyArMTYyLDcg QEAKIAogCS8qIGZyZWUgYWN0aXZlIG1idWZzLCBpZiBhbnkgKi8KIAl3aGlsZSAoKGxlID0gTElT VF9GSVJTVCgmbGMtPmxyb19hY3RpdmUpKSAhPSBOVUxMKSB7Ci0JCUxJU1RfUkVNT1ZFKGxlLCBu ZXh0KTsKKwkJdGNwX2xyb19hY3RpdmVfcmVtb3ZlKGxlKTsKIAkJbV9mcmVlbShsZS0+bV9oZWFk KTsKIAl9CiAKQEAgLTIzNCw3ICsyNjcsNyBAQAogCXN0cnVjdCBscm9fZW50cnkgKmxlOwogCiAJ d2hpbGUgKChsZSA9IExJU1RfRklSU1QoJmxjLT5scm9fYWN0aXZlKSkgIT0gTlVMTCkgewotCQlM SVNUX1JFTU9WRShsZSwgbmV4dCk7CisJCXRjcF9scm9fYWN0aXZlX3JlbW92ZShsZSk7CiAJCXRj cF9scm9fZmx1c2gobGMsIGxlKTsKIAl9CiB9CkBAIC0yNTIsNyArMjg1LDcgQEAKIAl0aW1ldmFs c3ViKCZ0diwgdGltZW91dCk7CiAJTElTVF9GT1JFQUNIX1NBRkUobGUsICZsYy0+bHJvX2FjdGl2 ZSwgbmV4dCwgbGVfdG1wKSB7CiAJCWlmICh0aW1ldmFsY21wKCZ0diwgJmxlLT5tdGltZSwgPj0p KSB7Ci0JCQlMSVNUX1JFTU9WRShsZSwgbmV4dCk7CisJCQl0Y3BfbHJvX2FjdGl2ZV9yZW1vdmUo bGUpOwogCQkJdGNwX2xyb19mbHVzaChsYywgbGUpOwogCQl9CiAJfQpAQCAtMzQ4LDcgKzM4MSw3 IEBACiAJbGMtPmxyb19xdWV1ZWQgKz0gbGUtPmFwcGVuZF9jbnQgKyAxOwogCWxjLT5scm9fZmx1 c2hlZCsrOwogCWJ6ZXJvKGxlLCBzaXplb2YoKmxlKSk7Ci0JTElTVF9JTlNFUlRfSEVBRCgmbGMt Pmxyb19mcmVlLCBsZSwgbmV4dCk7CisJdGNwX2xyb19lbnRyeV9wdXQobGMsIGxlKTsKIH0KIAog c3RhdGljIGludApAQCAtNjIwLDE2ICs2NTMsMTYgQEAKIAogCQkvKiBGbHVzaCBub3cgaWYgYXBw ZW5kaW5nIHdpbGwgcmVzdWx0IGluIG92ZXJmbG93LiAqLwogCQlpZiAobGUtPnBfbGVuID4gKGxj LT5scm9fbGVuZ3RoX2xpbSAtIHRjcF9kYXRhX2xlbikpIHsKLQkJCUxJU1RfUkVNT1ZFKGxlLCBu ZXh0KTsKKwkJCXRjcF9scm9fYWN0aXZlX3JlbW92ZShsZSk7CiAJCQl0Y3BfbHJvX2ZsdXNoKGxj LCBsZSk7CiAJCQlicmVhazsKIAkJfQogCiAJCS8qIFRyeSB0byBhcHBlbmQgdGhlIG5ldyBzZWdt ZW50LiAqLwogCQlpZiAoX19wcmVkaWN0X2ZhbHNlKHNlcSAhPSBsZS0+bmV4dF9zZXEgfHwKIAkJ ICAgICh0Y3BfZGF0YV9sZW4gPT0gMCAmJiBsZS0+YWNrX3NlcSA9PSB0aC0+dGhfYWNrKSkpIHsK IAkJCS8qIE91dCBvZiBvcmRlciBwYWNrZXQgb3IgZHVwbGljYXRlIEFDSy4gKi8KLQkJCUxJU1Rf UkVNT1ZFKGxlLCBuZXh0KTsKKwkJCXRjcF9scm9fYWN0aXZlX3JlbW92ZShsZSk7CiAJCQl0Y3Bf bHJvX2ZsdXNoKGxjLCBsZSk7CiAJCQlyZXR1cm4gKFRDUF9MUk9fQ0FOTk9UKTsKIAkJfQpAQCAt NjYyLDcgKzY5NSw3IEBACiAJCQkgKiBiZSBmdXJ0aGVyIGRlbGF5ZWQuCiAJCQkgKi8KIAkJCWlm IChsZS0+YXBwZW5kX2NudCA+PSBsYy0+bHJvX2Fja2NudF9saW0pIHsKLQkJCQlMSVNUX1JFTU9W RShsZSwgbmV4dCk7CisJCQkJdGNwX2xyb19hY3RpdmVfcmVtb3ZlKGxlKTsKIAkJCQl0Y3BfbHJv X2ZsdXNoKGxjLCBsZSk7CiAJCQl9CiAJCQlyZXR1cm4gKDApOwpAQCAtNjg2LDIyICs3MTksMjEg QEAKIAkJICogb3ZlcmZsb3csIHByby1hY3RpdmVseSBmbHVzaCBub3cuCiAJCSAqLwogCQlpZiAo bGUtPnBfbGVuID4gKGxjLT5scm9fbGVuZ3RoX2xpbSAtIGxjLT5pZnAtPmlmX210dSkpIHsKLQkJ CUxJU1RfUkVNT1ZFKGxlLCBuZXh0KTsKKwkJCXRjcF9scm9fYWN0aXZlX3JlbW92ZShsZSk7CiAJ CQl0Y3BfbHJvX2ZsdXNoKGxjLCBsZSk7CiAJCX0gZWxzZQogCQkJZ2V0bWljcm90aW1lKCZsZS0+ bXRpbWUpOwogCiAJCXJldHVybiAoMCk7CiAJfQogCiAJLyogVHJ5IHRvIGZpbmQgYW4gZW1wdHkg c2xvdC4gKi8KLQlpZiAoTElTVF9FTVBUWSgmbGMtPmxyb19mcmVlKSkKKwlsZSA9IHRjcF9scm9f ZW50cnlfZ2V0KGxjKTsKKwlpZiAobGUgPT0gTlVMTCkKIAkJcmV0dXJuIChUQ1BfTFJPX05PX0VO VFJJRVMpOwogCiAJLyogU3RhcnQgYSBuZXcgc2VnbWVudCBjaGFpbi4gKi8KLQlsZSA9IExJU1Rf RklSU1QoJmxjLT5scm9fZnJlZSk7Ci0JTElTVF9SRU1PVkUobGUsIG5leHQpOwotCUxJU1RfSU5T RVJUX0hFQUQoJmxjLT5scm9fYWN0aXZlLCBsZSwgbmV4dCk7CisJdGNwX2xyb19hY3RpdmVfaW5z ZXJ0KGxjLCBsZSk7CiAJZ2V0bWljcm90aW1lKCZsZS0+bXRpbWUpOwogCiAJLyogU3RhcnQgZmls bGluZyBpbiBkZXRhaWxzLiAqLwoK --b1_9224c4cda1a9d45d20fecae5fbdb2c16--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?differential-rev-PHID-DREV-mroevi6nzobvlsf24xxb-req>