Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 Mar 2016 11:42:05 +0000
From:      Olivier Duchateau <olivierd@freebsd.org>
To:        Josh Paetzel <jpaetzel@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r410200 - in head/sysutils: . catfish
Message-ID:  <20160306114205.e73102d615a6d07d979a8e95@freebsd.org>
In-Reply-To: <201603051905.u25J5Xfc028460@repo.freebsd.org>
References:  <201603051905.u25J5Xfc028460@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 5 Mar 2016 19:05:33 +0000 (UTC)
Josh Paetzel <jpaetzel@FreeBSD.org> wrote:

> Author: jpaetzel
> Date: Sat Mar  5 19:05:32 2016
> New Revision: 410200
> URL: https://svnweb.freebsd.org/changeset/ports/410200
> 
> Log:
>   Introduce a new port sysutils/catfish
>   
>   catfish is a GTK3 file finding utility.

Catfish can work perfectly, but I observed some mistakes.

Catfish uses the Python GObject bindings, so gtk30 is not sufficient.
Moreover I think Catfish is written for Python 3, see shebang in bin/catfish and setup.py (full path is currently wrong), but other files refer to python 2 or 3 (with correct path). I don't know which is the default version of Python on Debian / Ubuntu (maintainer of Catfish is also Xubuntu developer).

If you choose Python 3, add py3gobject3 to USE_GNOME macro, else it's pygobject3.

Sudo is required (see catfish_lib/SudoDialog.py) for one search engine. It exists also a test for pkexec (sysutils/polkit) but .policy file is missing (or .rules must be written by users).

About search engines, (I don't know which one is used by default), but there're:
- Zeitgeist (optional, through GObject Introspection)
- os.walk (function from os module)
- locate utility (it requires sudo in order to update database. In catfish_lib/catfishconfig.py, the locate database is not correct (at least on FreeBSD) according to locate(1).

> 
> Added:
>   head/sysutils/catfish/
>   head/sysutils/catfish/Makefile   (contents, props changed)
>   head/sysutils/catfish/distinfo   (contents, props changed)
>   head/sysutils/catfish/pkg-descr   (contents, props changed)
>   head/sysutils/catfish/pkg-plist   (contents, props changed)
> Modified:
>   head/sysutils/Makefile
> 
> Modified: head/sysutils/Makefile
> ==============================================================================
> --- head/sysutils/Makefile	Sat Mar  5 19:04:59 2016	(r410199)
> +++ head/sysutils/Makefile	Sat Mar  5 19:05:32 2016	(r410200)
> @@ -108,6 +108,7 @@
>      SUBDIR += burp
>      SUBDIR += busybox
>      SUBDIR += byobu
> +    SUBDIR += catfish
>      SUBDIR += cbsd
>      SUBDIR += ccd2iso
>      SUBDIR += cciss_vol_status
> 
> Added: head/sysutils/catfish/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/catfish/Makefile	Sat Mar  5 19:05:32 2016	(r410200)
> @@ -0,0 +1,22 @@
> +# $FreeBSD$
> +#
> +PORTNAME=	catfish
> +PORTVERSION=	1.4.1
> +CATEGORIES=	sysutils
> +MASTER_SITES=	http://launchpad.net/catfish-search/1.4/1.4.1/+download/
> +
> +MAINTAINER=	jpaetzel@FreeBSD.org
> +COMMENT=	GTK search utility
> +
> +BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}python-distutils-extra>0:${PORTSDIR}/devel/py-python-distutils-extra
> +RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pexpect>0:${PORTSDIR}/misc/py-pexpect
> +
> +USES=		python
> +USE_PYTHON=	distutils
> +USE_GNOME=	gtk30
> +
> +.include <bsd.port.pre.mk>
> +
> +PYDISTUTILS_INSTALLARGS=	-c -O1 --prefix=${PREFIX} --root=${STAGEDIR}
> +
> +.include <bsd.port.post.mk>
> 
> Added: head/sysutils/catfish/distinfo
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/catfish/distinfo	Sat Mar  5 19:05:32 2016	(r410200)
> @@ -0,0 +1,2 @@
> +SHA256 (catfish-1.4.1.tar.gz) = f804a1f499a9bc108cf8b2e7a39e3684dbe54711c2bdb7b4702cc957ce059896
> +SIZE (catfish-1.4.1.tar.gz) = 135767
> 
> Added: head/sysutils/catfish/pkg-descr
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/catfish/pkg-descr	Sat Mar  5 19:05:32 2016	(r410200)
> @@ -0,0 +1,3 @@
> +Catfish is a GTK based search utility.
> +
> +http://www.twotoasts.de/index.php/catfish/
> 
> Added: head/sysutils/catfish/pkg-plist
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/catfish/pkg-plist	Sat Mar  5 19:05:32 2016	(r410200)
> @@ -0,0 +1,83 @@
> +bin/catfish
> +%%PYTHON_SITELIBDIR%%/catfish/AboutCatfishDialog.py
> +%%PYTHON_SITELIBDIR%%/catfish/AboutCatfishDialog.pyc
> +%%PYTHON_SITELIBDIR%%/catfish/AboutCatfishDialog.pyo
> +%%PYTHON_SITELIBDIR%%/catfish/CatfishSearchEngine.py
> +%%PYTHON_SITELIBDIR%%/catfish/CatfishSearchEngine.pyc
> +%%PYTHON_SITELIBDIR%%/catfish/CatfishSearchEngine.pyo
> +%%PYTHON_SITELIBDIR%%/catfish/CatfishWindow.py
> +%%PYTHON_SITELIBDIR%%/catfish/CatfishWindow.pyc
> +%%PYTHON_SITELIBDIR%%/catfish/CatfishWindow.pyo
> +%%PYTHON_SITELIBDIR%%/catfish/__init__.py
> +%%PYTHON_SITELIBDIR%%/catfish/__init__.pyc
> +%%PYTHON_SITELIBDIR%%/catfish/__init__.pyo
> +%%PYTHON_SITELIBDIR%%/catfish_lib/AboutDialog.py
> +%%PYTHON_SITELIBDIR%%/catfish_lib/AboutDialog.pyc
> +%%PYTHON_SITELIBDIR%%/catfish_lib/AboutDialog.pyo
> +%%PYTHON_SITELIBDIR%%/catfish_lib/Builder.py
> +%%PYTHON_SITELIBDIR%%/catfish_lib/Builder.pyc
> +%%PYTHON_SITELIBDIR%%/catfish_lib/Builder.pyo
> +%%PYTHON_SITELIBDIR%%/catfish_lib/CatfishSettings.py
> +%%PYTHON_SITELIBDIR%%/catfish_lib/CatfishSettings.pyc
> +%%PYTHON_SITELIBDIR%%/catfish_lib/CatfishSettings.pyo
> +%%PYTHON_SITELIBDIR%%/catfish_lib/SudoDialog.py
> +%%PYTHON_SITELIBDIR%%/catfish_lib/SudoDialog.pyc
> +%%PYTHON_SITELIBDIR%%/catfish_lib/SudoDialog.pyo
> +%%PYTHON_SITELIBDIR%%/catfish_lib/Window.py
> +%%PYTHON_SITELIBDIR%%/catfish_lib/Window.pyc
> +%%PYTHON_SITELIBDIR%%/catfish_lib/Window.pyo
> +%%PYTHON_SITELIBDIR%%/catfish_lib/__init__.py
> +%%PYTHON_SITELIBDIR%%/catfish_lib/__init__.pyc
> +%%PYTHON_SITELIBDIR%%/catfish_lib/__init__.pyo
> +%%PYTHON_SITELIBDIR%%/catfish_lib/catfishconfig.py
> +%%PYTHON_SITELIBDIR%%/catfish_lib/catfishconfig.pyc
> +%%PYTHON_SITELIBDIR%%/catfish_lib/catfishconfig.pyo
> +%%PYTHON_SITELIBDIR%%/catfish_lib/helpers.py
> +%%PYTHON_SITELIBDIR%%/catfish_lib/helpers.pyc
> +%%PYTHON_SITELIBDIR%%/catfish_lib/helpers.pyo
> +share/appdata/catfish.appdata.xml
> +share/applications/catfish.desktop
> +%%DATADIR%%/appdata/catfish.appdata.xml.in
> +%%DATADIR%%/ui/AboutCatfishDialog.ui
> +%%DATADIR%%/ui/CatfishWindow.ui
> +%%DATADIR%%/ui/about_catfish_dialog.xml
> +%%DATADIR%%/ui/catfish_window.xml
> +%%PORTDOCS%%%%DOCSDIR%%/README
> +share/icons/hicolor/scalable/apps/catfish.svg
> +share/locale/ar/LC_MESSAGES/catfish.mo
> +share/locale/be/LC_MESSAGES/catfish.mo
> +share/locale/bg/LC_MESSAGES/catfish.mo
> +share/locale/ca/LC_MESSAGES/catfish.mo
> +share/locale/cs/LC_MESSAGES/catfish.mo
> +share/locale/de/LC_MESSAGES/catfish.mo
> +share/locale/el/LC_MESSAGES/catfish.mo
> +share/locale/en_AU/LC_MESSAGES/catfish.mo
> +share/locale/eo/LC_MESSAGES/catfish.mo
> +share/locale/es/LC_MESSAGES/catfish.mo
> +share/locale/eu/LC_MESSAGES/catfish.mo
> +share/locale/fi/LC_MESSAGES/catfish.mo
> +share/locale/fr/LC_MESSAGES/catfish.mo
> +share/locale/hr/LC_MESSAGES/catfish.mo
> +share/locale/hu/LC_MESSAGES/catfish.mo
> +share/locale/id/LC_MESSAGES/catfish.mo
> +share/locale/is/LC_MESSAGES/catfish.mo
> +share/locale/it/LC_MESSAGES/catfish.mo
> +share/locale/ja/LC_MESSAGES/catfish.mo
> +share/locale/ko/LC_MESSAGES/catfish.mo
> +share/locale/lt/LC_MESSAGES/catfish.mo
> +share/locale/lv/LC_MESSAGES/catfish.mo
> +share/locale/ml/LC_MESSAGES/catfish.mo
> +share/locale/nl/LC_MESSAGES/catfish.mo
> +share/locale/pl/LC_MESSAGES/catfish.mo
> +share/locale/pt/LC_MESSAGES/catfish.mo
> +share/locale/pt_BR/LC_MESSAGES/catfish.mo
> +share/locale/ru/LC_MESSAGES/catfish.mo
> +share/locale/si/LC_MESSAGES/catfish.mo
> +share/locale/sk/LC_MESSAGES/catfish.mo
> +share/locale/sr/LC_MESSAGES/catfish.mo
> +share/locale/sv/LC_MESSAGES/catfish.mo
> +share/locale/tr/LC_MESSAGES/catfish.mo
> +share/locale/uk/LC_MESSAGES/catfish.mo
> +share/locale/zh_CN/LC_MESSAGES/catfish.mo
> +share/locale/zh_TW/LC_MESSAGES/catfish.mo
> +share/man/man1/catfish.1
> 


-- 
Olivier Duchateau <olivierd@freebsd.org>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160306114205.e73102d615a6d07d979a8e95>