From owner-svn-src-head@freebsd.org Tue Jun 5 13:07:07 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B9C4FD0C3B; Tue, 5 Jun 2018 13:07:07 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pl0-x241.google.com (mail-pl0-x241.google.com [IPv6:2607:f8b0:400e:c01::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EE57F76C55; Tue, 5 Jun 2018 13:07:06 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pl0-x241.google.com with SMTP id f1-v6so1484614plt.6; Tue, 05 Jun 2018 06:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jeZ0DxM2P4AKmhWV3bVptXbRwU8js5z9C8iEQ7HpD8Y=; b=gSKPyK5rRo7hTW0xz6M1FViyfetmvz97I2gwFU6t2/94Yg2gCxQ6lf0yAB+BAvCW4Y gxMvDD5tbb4R7Mtay1xKdwgZzdcYF9R8U8/uO62+eMoCQHdVA8+J+fB8jq9qu07xz2J5 Op79P4lHc5MaSp/HcRDvdeDkOdf/UPDmCkN0jVgePsX9hJdozMiakJiRcDe1XzWD4RGR iBPmOcNTZtw/6lHKPMdToC17ZHNzZ/pAyZzyn/ilyoajTpoLrIVF6jWDk2afb1xSzuvK jJ7OcMb3mNjO+NqI9fS9g5il2+ctIfnzfYckfXYPm87KfnvmCBntNDqVMjyZ6/j2fZF9 MFxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=jeZ0DxM2P4AKmhWV3bVptXbRwU8js5z9C8iEQ7HpD8Y=; b=VesN+wU6jo1nSwOMFsxhNH6NxTLK+g0cm+J7pj+HkAUwEmycpHkOATTAQdtqxLrVsH 1D8pz6Z0eBS/O3uj0/OpFUdNELXhDCpNui3Lbu8woDTGIF4xj4NpGSwiBqJYzGO8rA85 SrfVSr2008gbhSj4Yq88lA5qpuv+0crjxRxIgDynVawNAhIM6bGtbTaQVGgtmB943L3u F3US6UXwHOV1TIaMC25wT+oxhUGQr8NuoKvAOoF/Pb6uu7R18/YVTVRJssdaTTeErUh6 RqnMLce1L5ZE1cFVdBHtxzsKn0H4tLMgGv/ir3/wf/Ph973M1FcehQ1N6ATRHNWqa0rN I6+A== X-Gm-Message-State: ALKqPwcJP5Zpa0PoTvZ4LJggaOyTc+fZoMelUKINkmRR7SxsUOujJye0 uMbFhh59AKU77EN2KwnAc4E= X-Google-Smtp-Source: ADUXVKLxDqmtN5TGAZQib1r//WOmjwfuxCvDQk8m/tk0s1CIDY8uhYGqCab6uLfZ0VIQHKb9cYg2Uw== X-Received: by 2002:a17:902:b588:: with SMTP id a8-v6mr25828740pls.308.1528204026042; Tue, 05 Jun 2018 06:07:06 -0700 (PDT) Received: from raichu (toroon0560w-lp140-02-70-49-169-156.dsl.bell.ca. [70.49.169.156]) by smtp.gmail.com with ESMTPSA id p2-v6sm45637656pgq.14.2018.06.05.06.07.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jun 2018 06:07:05 -0700 (PDT) Sender: Mark Johnston Date: Tue, 5 Jun 2018 09:07:02 -0400 From: Mark Johnston To: Ganbold Tsagaankhuu Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334626 - in head: lib/libc/amd64 lib/libc/amd64/sys lib/libc/arm lib/libc/arm/sys lib/libc/i386 lib/libc/i386/sys lib/libc/mips lib/libc/mips/sys lib/libc/powerpc lib/libc/powerpc/sys ... Message-ID: <20180605130702.GB87893@raichu> References: <201806041935.w54JZFsF020741@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 13:07:07 -0000 On Tue, Jun 05, 2018 at 03:50:12PM +0800, Ganbold Tsagaankhuu wrote: > On Tue, Jun 5, 2018 at 3:35 AM, Mark Johnston wrote: > > > Author: markj > > Date: Mon Jun 4 19:35:15 2018 > > New Revision: 334626 > > URL: https://svnweb.freebsd.org/changeset/base/334626 > > > > Log: > > Reimplement brk() and sbrk() to avoid the use of _end. > > > > Previously, libc.so would initialize its notion of the break address > > using _end, a special symbol emitted by the static linker following > > the bss section. Compatibility issues between lld and ld.bfd could > > cause the wrong definition of _end (libc.so's definition rather than > > that of the executable) to be used, breaking the brk()/sbrk() > > interface. > > > > Avoid this problem and future interoperability issues by simply not > > relying on _end. Instead, modify the break() system call to return > > the kernel's view of the current break address, and have libc > > initialize its state using an extra syscall upon the first use of the > > interface. As a side effect, this appears to fix brk()/sbrk() usage > > in executables run with rtld direct exec, since the kernel and libc.so > > no longer maintain separate views of the process' break address. > > > > > Maybe it is not really related, or I'm doing something wrong, but when I > try to run release.sh script on FreeBSD 11.0-RELEASE-p9 to build pine64 > image, it stops with error: r334653 should fix that, sorry.