Date: Wed, 29 Jun 2011 17:59:54 +0800 From: Kevin Lo <kevlo@kevlo.org> To: Damjan Marion <damjan.marion@gmail.com> Cc: freebsd-arm@freebsd.org Subject: Re: Few issues with Marvell code Message-ID: <1309341594.10141.9.camel@srgsec> In-Reply-To: <B823839E-A0B2-4994-BDD8-6AC8747DCCEC@gmail.com> References: <B823839E-A0B2-4994-BDD8-6AC8747DCCEC@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2011-05-03 at 22:42 +0200, Damjan Marion wrote:
> Hi,
Hi,
> During my attempt to bring up 88F5181L I found few issues with current marvell code:
>
> 1. There is a typo in sys/arm/mv/common.c
>
> - { "mvrl,pcie", &decode_win_pcie_setup, NULL },
> + { "mrvl,pcie", &decode_win_pcie_setup, NULL },
Indeed. Committed, thanks!
> 2. Even if this is fixed, decode_win_pcie_setup will not be executed as in FDT file pci tree sits outside of SOC tree
>
>
> 3. CPU decode windows setup in FDT localbus tree is missing target, instead target is hardcoded to 1:
>
> cpu_win_tbl[t].target = 1;
>
> On other side 1st column looks like a sequence. Is this 1st column needed?
> Can we extend this definition to also have target defined?
>
> I.e. In case of 88F5181L I need to add following window, and it will be more convenient to do that in FDT file.
>
> cpu_win_tbl[++t].target = 0x04;
> cpu_win_tbl[t].attr = 0x79;
> cpu_win_tbl[t].base = 0xf0000000;
> cpu_win_tbl[t].size = 0x01000000;
> cpu_win_tbl[t].remap = -1;
I tried to boot kernel.bin used the generic DB-88F5XXX kernel
configuration on the 88F5182 board, it doesn't work either.
I will further investigate.
> Thanks,
>
> Damjan
Kevin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1309341594.10141.9.camel>