Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Nov 2008 21:07:34 +0000 (UTC)
From:      Ed Schouten <ed@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r185106 - head/sys/dev/nmdm
Message-ID:  <200811192107.mAJL7Ymt028502@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ed
Date: Wed Nov 19 21:07:33 2008
New Revision: 185106
URL: http://svn.freebsd.org/changeset/base/185106

Log:
  Make nmdm(4) use MPSAFE callouts.
  
  For some reason the nmdm(4) driver doesn't use CALLOUT_MPSAFE, even
  though we live in the MPSAFE TTY era. Add the CALLOUT_MPSAFE flags.
  System survives.

Modified:
  head/sys/dev/nmdm/nmdm.c

Modified: head/sys/dev/nmdm/nmdm.c
==============================================================================
--- head/sys/dev/nmdm/nmdm.c	Wed Nov 19 20:38:10 2008	(r185105)
+++ head/sys/dev/nmdm/nmdm.c	Wed Nov 19 21:07:33 2008	(r185106)
@@ -109,12 +109,12 @@ nmdm_alloc(unsigned long unit)
 	ns->ns_part1.np_pair = ns;
 	ns->ns_part1.np_other = &ns->ns_part2;
 	TASK_INIT(&ns->ns_part1.np_task, 0, nmdm_task_tty, &ns->ns_part1);
-	callout_init(&ns->ns_part1.np_callout, 0);
+	callout_init(&ns->ns_part1.np_callout, CALLOUT_MPSAFE);
 
 	ns->ns_part2.np_pair = ns;
 	ns->ns_part2.np_other = &ns->ns_part1;
 	TASK_INIT(&ns->ns_part2.np_task, 0, nmdm_task_tty, &ns->ns_part2);
-	callout_init(&ns->ns_part2.np_callout, 0);
+	callout_init(&ns->ns_part2.np_callout, CALLOUT_MPSAFE);
 
 	/* Create device nodes. */
 	tp = ns->ns_part1.np_tty = tty_alloc(&nmdm_class, &ns->ns_part1,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811192107.mAJL7Ymt028502>