Date: Sun, 05 Dec 2004 23:37:10 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Marcel Moolenaar <marcel@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys vnode.h src/sys/gnu/ext2fs ext2_vnops.c src/sys/nfsclient nfs_vnops.c src/sys/ufs/ufs ufs_vnops.c Message-ID: <68666.1102286230@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 05 Dec 2004 22:30:29 GMT." <200412052230.iB5MUTZs021927@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200412052230.iB5MUTZs021927@repoman.freebsd.org>, Marcel Moolenaar writes: >marcel 2004-12-05 22:30:29 UTC > > FreeBSD src repository > > Modified files: > sys/sys vnode.h > sys/gnu/ext2fs ext2_vnops.c > sys/nfsclient nfs_vnops.c > sys/ufs/ufs ufs_vnops.c > Log: > Fix null-pointer indirect function calls introduced in the previous > commit. In the new world order, the transitive closure on the vector > operations is not precomputed. As such, it's unsafe to actually use > any of the function pointers in an indirect function call. Uhm not really. You'll notice that these three cases vector through a fifo_*specop*. The "specop" as opposed to "vnodeop", means that you're supposed to know what you're doing. Did you actually get a zero pointer deref on this ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?68666.1102286230>