From owner-freebsd-bugs@FreeBSD.ORG Tue Aug 11 06:20:03 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D6DC106564A for ; Tue, 11 Aug 2009 06:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D44198FC25 for ; Tue, 11 Aug 2009 06:20:02 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7B6K28r024520 for ; Tue, 11 Aug 2009 06:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7B6K2x9024519; Tue, 11 Aug 2009 06:20:02 GMT (envelope-from gnats) Resent-Date: Tue, 11 Aug 2009 06:20:02 GMT Resent-Message-Id: <200908110620.n7B6K2x9024519@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Andrey V. Elsukov" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C370C106566B for ; Tue, 11 Aug 2009 06:16:54 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id B28408FC1F for ; Tue, 11 Aug 2009 06:16:54 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7B6Gsgk017103 for ; Tue, 11 Aug 2009 06:16:54 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n7B6GsE4017102; Tue, 11 Aug 2009 06:16:54 GMT (envelope-from nobody) Message-Id: <200908110616.n7B6GsE4017102@www.freebsd.org> Date: Tue, 11 Aug 2009 06:16:54 GMT From: "Andrey V. Elsukov" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/137656: [geom][patch] gpart drops core when adding partition to non-existent geom X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2009 06:20:03 -0000 >Number: 137656 >Category: bin >Synopsis: [geom][patch] gpart drops core when adding partition to non-existent geom >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Aug 11 06:20:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Andrey V. Elsukov >Release: 8.0-BETA2 >Organization: >Environment: 8.0-BETA2 FreeBSD 8.0-BETA2 #0: Wed Jul 15 21:48:41 UTC 2009 root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: gpart crashes when adding partitions to non-existent geom. Problem is in gpart_autofill function. It doesn't check returned value after calling find_geom(). And next function doing access to NULL pointer. >How-To-Repeat: > gpart show => 34 312581741 ad4 GPT (149G) 34 256 1 freebsd-boot (128K) 290 4194304 2 freebsd-swap (2.0G) 4194594 125829120 3 freebsd-zfs (60G) 130023714 182558061 - free - (87G) > sudo gpart add -t freebsd-zfs ad6 Segmentation fault (core dumped) >Fix: After my patch: > sudo ./gpart add -t freebsd-zfs ad6 gpart: No such geom: ad6. Patch attached with submission follows: --- src/sbin/geom/class/part/geom_part.c 2009-07-14 12:54:23.444482747 +0400 +++ src/sbin/geom/class/part/geom_part.c 2009-08-11 09:58:13.246739711 +0400 @@ -275,7 +275,10 @@ if (error) return (error); cp = find_class(&mesh, gctl_get_ascii(req, "class")); - gp = find_geom(cp, gctl_get_ascii(req, "geom")); + s = gctl_get_ascii(req, "geom"); + gp = find_geom(cp, s); + if (gp == NULL) + errx(EXIT_FAILURE, "No such geom: %s.", s); first = atoll(find_geomcfg(gp, "first")); last = atoll(find_geomcfg(gp, "last")); grade = ~0ULL; >Release-Note: >Audit-Trail: >Unformatted: