Date: Sat, 21 Apr 2001 12:43:15 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.ORG> To: Peter Pentchev <roam@orbitel.bg> Cc: Bruce Evans <bde@zeta.org.au>, Matt Dillon <dillon@earth.backplane.com>, Alfred Perlstein <bright@wintelcom.net>, Terry Lambert <tlambert@primenet.com>, arch@FreeBSD.ORG Subject: Re: Found BAD BUG: squashed Message-ID: <Pine.NEB.3.96L.1010421124156.41843K-100000@fledge.watson.org> In-Reply-To: <20010419154611.D1067@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 19 Apr 2001, Peter Pentchev wrote: > On Thu, Apr 19, 2001 at 10:44:12PM +1000, Bruce Evans wrote: > > On Thu, 19 Apr 2001, Peter Pentchev wrote: > > > > > Would there be any bad implications of upping cr_ref to 32-bit before 4.3? > > > Besides binary compatibility? (I know, I know.. recompiling third-party > > > kernel modules and all..) > > > > It's hard to tell with only 1 day to test :-). Non-bloatage of the struct > > makes bugs less obvious. If not all the modules are compiled, then some > > modules may provide (nonzero) garbage in the padding after cr_ref. This > > will be interpreted as a large refcount by new kernels and ucreds will > > never be freed. > > Ack. I never thought of stale modules. Point taken - there might also > be LOTS of other things I - or others - have not thought of :) > > G'luck, > Peter Note: stale modules may be OK as long as (a) the structure isn't rearranged and (b) they are using the base kernel's cr*() calls to manipulate credentials. However, this is something that would have to be extensively tested. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1010421124156.41843K-100000>