From owner-freebsd-arch Sat Apr 21 9:43:26 2001 Delivered-To: freebsd-arch@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 9613D37B422 for ; Sat, 21 Apr 2001 09:43:23 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.3/8.11.3) with SMTP id f3LGhFf62187; Sat, 21 Apr 2001 12:43:15 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Sat, 21 Apr 2001 12:43:15 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Peter Pentchev Cc: Bruce Evans , Matt Dillon , Alfred Perlstein , Terry Lambert , arch@FreeBSD.ORG Subject: Re: Found BAD BUG: squashed In-Reply-To: <20010419154611.D1067@ringworld.oblivion.bg> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 19 Apr 2001, Peter Pentchev wrote: > On Thu, Apr 19, 2001 at 10:44:12PM +1000, Bruce Evans wrote: > > On Thu, 19 Apr 2001, Peter Pentchev wrote: > > > > > Would there be any bad implications of upping cr_ref to 32-bit before 4.3? > > > Besides binary compatibility? (I know, I know.. recompiling third-party > > > kernel modules and all..) > > > > It's hard to tell with only 1 day to test :-). Non-bloatage of the struct > > makes bugs less obvious. If not all the modules are compiled, then some > > modules may provide (nonzero) garbage in the padding after cr_ref. This > > will be interpreted as a large refcount by new kernels and ucreds will > > never be freed. > > Ack. I never thought of stale modules. Point taken - there might also > be LOTS of other things I - or others - have not thought of :) > > G'luck, > Peter Note: stale modules may be OK as long as (a) the structure isn't rearranged and (b) they are using the base kernel's cr*() calls to manipulate credentials. However, this is something that would have to be extensively tested. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message