From owner-svn-src-head@FreeBSD.ORG Mon Jan 30 11:40:34 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B883E106566B for ; Mon, 30 Jan 2012 11:40:34 +0000 (UTC) (envelope-from markm@FreeBSD.org) Received: from gromit.grondar.org (grandfather.grondar.org [93.89.92.32]) by mx1.freebsd.org (Postfix) with ESMTP id 779888FC16 for ; Mon, 30 Jan 2012 11:40:34 +0000 (UTC) Received: from uucp by gromit.grondar.org with local-rmail (Exim 4.76 (FreeBSD)) (envelope-from ) id 1RrpVq-00093f-Se for svn-src-head@freebsd.org; Mon, 30 Jan 2012 11:35:06 +0000 Received: from localhost ([127.0.0.1] helo=groundzero.grondar.org) by groundzero.grondar.org with esmtp (Exim 4.77 (FreeBSD)) (envelope-from ) id 1RrpR9-0006D5-To; Mon, 30 Jan 2012 11:30:15 +0000 To: Andrey Chernov In-reply-to: <20120129125738.GA26520@vniz.net> References: <20120126143819.GA88677@vniz.net> <20120126155626.GA92229@vniz.net> <201201261132.38320.jhb@freebsd.org> <20120126165521.GA92622@vniz.net> <20120126175243.GA19199@zim.MIT.EDU> <20120126181340.GA93157@vniz.net> <20120129125738.GA26520@vniz.net> From: Mark Murray From: Mark Murray Date: Mon, 30 Jan 2012 11:30:15 +0000 Message-Id: Cc: src-committers@FreeBSD.ORG, John Baldwin , svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG, David Schultz , Mark Murray Subject: Re: svn commit: r230230 - head/sys/dev/random X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2012 11:40:34 -0000 Andrey Chernov writes: > On Thu, Jan 26, 2012 at 10:13:41PM +0400, Andrey Chernov wrote: > > On Thu, Jan 26, 2012 at 12:52:43PM -0500, David Schultz wrote: > > > Why complicate things with atomics at all? A race might result in > > > arc4random(9) being seeded multiple times, but that's harmless. > > > > Multiply seeding in line is harmless, just waste of time and resources. > > Other case is one missing seeding when variable is set concurrently with > > its read. I see no complication using atomic. Latest version is even > > shorter than previous ones. > > Well, I almost forget about my special case: I have personal prohibition > from @secteam (5 years old already) to commit anything to all RNG areas. > > So, the question is: could anyone of you commit some version from this > thread, please? Sure; I'll do it. Please give me your test code/cases. > I don't insist of atomics in this sutuation, so you can peek any version > you like. I'll need to clearly see what works. M -- Mark R V Murray Cert APS(Open) Dip Phys(Open) BSc Open(Open) BSc(Hons)(Open) Pi: 132511160