From owner-svn-src-head@FreeBSD.ORG Fri May 11 20:12:05 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8FE1F1065670; Fri, 11 May 2012 20:12:05 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 45DF08FC15; Fri, 11 May 2012 20:12:05 +0000 (UTC) Received: from [172.24.128.81] ([192.75.139.248]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id q4BK90IZ016528 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Fri, 11 May 2012 14:09:03 -0600 (MDT) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <4FAD0DF4.9000609@freebsd.org> Date: Fri, 11 May 2012 16:08:54 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <36CFD0BA-5047-42C5-9FE5-5D057CEFBAD9@bsdimp.com> References: <201205111237.q4BCbGX2083596@svn.freebsd.org> <20120511124820.GN2358@deviant.kiev.zoral.com.ua> <4FAD0DF4.9000609@freebsd.org> To: Colin Percival X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Fri, 11 May 2012 14:09:05 -0600 (MDT) Cc: Konstantin Belousov , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Gabor Kovesdan Subject: Re: svn commit: r235267 - in head/usr.bin/sort: . nls X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2012 20:12:05 -0000 On May 11, 2012, at 9:02 AM, Colin Percival wrote: > On 05/11/12 05:48, Konstantin Belousov wrote: >> On Fri, May 11, 2012 at 12:37:16PM +0000, Gabor Kovesdan wrote: >>> +bool byte_sort =3D false; + +static wchar_t **wmonths =3D NULL; = +static >>> unsigned char **cmonths =3D NULL; >>=20 >> Such initializations are useless. You only increase the size of the = binary=20 >> on the disk as the consequence. >=20 > I just tested this hypothesis, and found no change in binary size = using > either clang or gcc46. Presumably they're smart enough to ignore = explicit > (and unnecessary) initializations of statics to zero. How did you test this? size(1) or ls(1)? If ls, then you may be = running into the page rounding of the .text and .data sections... Warner