Date: Fri, 24 Jan 2014 21:34:04 +0400 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r340875 - head/graphics/py-pyglet Message-ID: <20140124173403.GA33026@hades.panopticon> In-Reply-To: <08A02A920829DC4130029A7F@ogg.in.absolight.net> References: <201401240125.s0O1PcNR065306@svn.freebsd.org> <02676048890BF03180E6CFAB@atuin.in.mat.cc> <20140124124924.GF28542@hades.panopticon> <08A02A920829DC4130029A7F@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
* Mathieu Arnold (mat@FreeBSD.org) wrote:
> | I don't think that matters unless ${WRKSRC} is deleted in the
> | process. Actually, it's even better, as if for some reason some
> | command leaves something behind (a corefile or a log) in it's current
> | directory, it'll end up in ${WRKSRC} and to a ports' directory.
>
> Well, yes, but no, you're missing the point, the idea is to have a stable
> and consistent way of doing things, so that if anyone needs to touch any
> port, (s)he doesn't have figure out what the current directory currently is.
One should _never_ depend on current directory unless he changes
it in the same line. Because it's handling is (as you say) inconsistent
among make versions, and because it's highly error prone (changing
or reordering lines will break unrelated stuff). Also, all talk about
this is useless unless whole portstree is converted and then keept
consistent, which IHMO is completely useless.
> I was fine before because each line was executed in its own shell, but now,
> the whole bloc is executed in one shell invocation.
Has this `now' happened in HEAD?
Both 9.0-RELEASE and 10.0-RELEASE (after bmake switch) behave like this:
% cat /tmp/Makefile
all:
@pwd
@cd ..; pwd
@pwd
% make -C tmp
/tmp
/
/tmp
Although I remember having cd in one line affect pwd in another some
time ago.
--
Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140124173403.GA33026>