From nobody Thu Oct 28 17:59:20 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A140A182CA28; Thu, 28 Oct 2021 17:59:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HgCxQ498Sz4ZVc; Thu, 28 Oct 2021 17:59:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 018A7AB14; Thu, 28 Oct 2021 17:59:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: 5306ca9a8e2f - stable/13 - nehemiah: manually assemble xstore(-rng) To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org References: <202110280036.19S0aUlw016872@gitrepo.freebsd.org> <5f2a0484-6016-2f9d-2697-54000cb8ee07@FreeBSD.org> From: John Baldwin Message-ID: Date: Thu, 28 Oct 2021 10:59:20 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 10/28/21 10:52 AM, Konstantin Belousov wrote: > On Thu, Oct 28, 2021 at 08:45:30AM -0700, John Baldwin wrote: >> On 10/27/21 5:36 PM, Konstantin Belousov wrote: >>> The branch stable/13 has been updated by kib: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=5306ca9a8e2f2b3bfa7d1ebc784dedbd5422fdae >>> >>> commit 5306ca9a8e2f2b3bfa7d1ebc784dedbd5422fdae >>> Author: Konstantin Belousov >>> AuthorDate: 2021-10-20 22:42:05 +0000 >>> Commit: Konstantin Belousov >>> CommitDate: 2021-10-28 00:35:54 +0000 >>> >>> nehemiah: manually assemble xstore(-rng) >>> PR: 259218 >>> (cherry picked from commit 362c6d8dec6dfbedc5717e45769042279a1dd3df) >> >> Note that dim@ merged the LLVM fix to 13 yesterday. :) > I delegate the revert to dim. > > Seriously thought, I think that the kernel patch should be left in tree > for some more time, because people update kernel much more often than > userspace. That is fair. We could perhaps make it an #ifdef on the clang version perhaps (clang <= 13 perhaps). That would let us know when we can safely remove it and still have it readable in the source in the #else case. I can maybe try coming up with that. -- John Baldwin