From owner-freebsd-current Wed Nov 27 1:58:39 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB9F237B401 for ; Wed, 27 Nov 2002 01:58:38 -0800 (PST) Received: from hawk.mail.pas.earthlink.net (hawk.mail.pas.earthlink.net [207.217.120.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14AC643E9C for ; Wed, 27 Nov 2002 01:58:38 -0800 (PST) (envelope-from tlambert2@mindspring.com) Received: from pool0035.cvx40-bradley.dialup.earthlink.net ([216.244.42.35] helo=mindspring.com) by hawk.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 18Gyxo-0007HG-00; Wed, 27 Nov 2002 01:58:36 -0800 Message-ID: <3DE496FB.66A71BF3@mindspring.com> Date: Wed, 27 Nov 2002 01:57:15 -0800 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Julian Elischer , Nate Lawson , current@FreeBSD.ORG Subject: Re: [PATCH] Searching for users of netncp and nwfs to help References: <200211270742.XAA57750@InterJet.elischer.org> <3DE495AD.6C73EF3D@mindspring.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Terry Lambert wrote: > The main problem here is that lockmgr() is being called to lock > things that technically don't need to be locked, at all, really, > to insure that operations are not attempted concurrently. It's > not really necessary: the server will refuse additional requests > on a connection, when there is one request outstanding. In case this wasn't clear to whoever was thinking of doing the work: add a serialization barrier at the ncp_* layer. You can remove it later, without any other code being adversely affected, if you add a connection pool later. Note also that the credentials can be passed on the VC, if you don't mind not running on NetWare prior to 3.1b. I recommend this, since it means connection, but not credential, sharing between processes for threads in the work-to-do pool. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message