Date: Mon, 07 Jan 2019 18:24:35 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234700] cad/opencascade: Do not set VIS_CMAKE_ON twice Message-ID: <bug-234700-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234700 Bug ID: 234700 Summary: cad/opencascade: Do not set VIS_CMAKE_ON twice Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: thierry@FreeBSD.org Reporter: tobik@freebsd.org CC: thierry@FreeBSD.org Assignee: thierry@FreeBSD.org Flags: maintainer-feedback?(thierry@FreeBSD.org) Attachment #200879 maintainer-approval?(thierry@FreeBSD.org) Flags: CC: thierry@FreeBSD.org Created attachment 200879 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200879&action= =3Dedit cad__opencascade.diff The port specifies VIS_CMAKE_ON twice like this VIS_CMAKE_ON=3D -DUSE_FREEIMAGE:BOOL=3DON -DUSE_GL2PS:BOOL=3DON = \ -DUSE_FREETYPE:BOOL=3DON [...] VIS_CMAKE_ON=3D -D3RDPARTY_FREETYPE_DIR=3D${LOCALBASE} The second VIS_CMAKE_ON overwrites the earlier one. Should the values be concatenated or can the first VIS_CMAKE_ON be removed? The attached patch concatenates them and also switches things to using the opt_CMAKE_BOOL options helper which is a little easier to read. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234700-7788>