From owner-freebsd-ports-bugs@freebsd.org Mon Jan 7 18:24:38 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3312D149B244 for ; Mon, 7 Jan 2019 18:24:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C15EE720D3 for ; Mon, 7 Jan 2019 18:24:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 850CA149B243; Mon, 7 Jan 2019 18:24:37 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73724149B242 for ; Mon, 7 Jan 2019 18:24:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 127AC720CE for ; Mon, 7 Jan 2019 18:24:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 59A6218A97 for ; Mon, 7 Jan 2019 18:24:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x07IOabV030994 for ; Mon, 7 Jan 2019 18:24:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x07IOa3A030993 for ports-bugs@FreeBSD.org; Mon, 7 Jan 2019 18:24:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234700] cad/opencascade: Do not set VIS_CMAKE_ON twice Date: Mon, 07 Jan 2019 18:24:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: thierry@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter cc flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 18:24:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234700 Bug ID: 234700 Summary: cad/opencascade: Do not set VIS_CMAKE_ON twice Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: thierry@FreeBSD.org Reporter: tobik@freebsd.org CC: thierry@FreeBSD.org Assignee: thierry@FreeBSD.org Flags: maintainer-feedback?(thierry@FreeBSD.org) Attachment #200879 maintainer-approval?(thierry@FreeBSD.org) Flags: CC: thierry@FreeBSD.org Created attachment 200879 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200879&action= =3Dedit cad__opencascade.diff The port specifies VIS_CMAKE_ON twice like this VIS_CMAKE_ON=3D -DUSE_FREEIMAGE:BOOL=3DON -DUSE_GL2PS:BOOL=3DON = \ -DUSE_FREETYPE:BOOL=3DON [...] VIS_CMAKE_ON=3D -D3RDPARTY_FREETYPE_DIR=3D${LOCALBASE} The second VIS_CMAKE_ON overwrites the earlier one. Should the values be concatenated or can the first VIS_CMAKE_ON be removed? The attached patch concatenates them and also switches things to using the opt_CMAKE_BOOL options helper which is a little easier to read. --=20 You are receiving this mail because: You are the assignee for the bug.=