From owner-cvs-sys Thu Mar 23 01:08:12 1995 Return-Path: cvs-sys-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id BAA05109 for cvs-sys-outgoing; Thu, 23 Mar 1995 01:08:12 -0800 Received: from estienne.cs.berkeley.edu (estienne.CS.Berkeley.EDU [128.32.42.147]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id BAA05101; Thu, 23 Mar 1995 01:08:02 -0800 Received: from localhost (localhost [127.0.0.1]) by estienne.cs.berkeley.edu (8.6.9/8.6.9) with SMTP id BAA02336; Thu, 23 Mar 1995 01:07:50 -0800 Message-Id: <199503230907.BAA02336@estienne.cs.berkeley.edu> X-Authentication-Warning: estienne.cs.berkeley.edu: Host localhost didn't use HELO protocol To: "Rodney W. Grimes" cc: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com Subject: Re: cvs commit: src/sys/i386/isa aha1742.c ultra14f.c In-reply-to: Your message of "Thu, 23 Mar 1995 01:00:22 PST." <199503230900.BAA04876@freefall.cdrom.com> Date: Thu, 23 Mar 1995 01:07:50 -0800 From: "Justin T. Gibbs" Sender: cvs-sys-owner@freebsd.org Precedence: bulk >rgrimes 95/03/23 01:00:21 > > Modified: sys/i386/isa aha1742.c ultra14f.c > Log: > Change MAX_SLOTS -> EISA_MAX_SLOTS and correct comments. Add this to > ultra14f.c and eliminate constants. > > Correct EISA slot scan loops to look at slots 1 to 15 inclusive (off > by 1 errors all over the place). Other drivers need this, I will get > to it after a little more work. > > Correct the ultrastore EISA probe so that it starts after the last > EISA slot probed instead of starting over from slot 0. > > We need an eisa.h to move a lot of common constants into. I will > write it if someone tells me where it should go (sys/eisa?). Yes, it should go into sys/eisa along with Julian's EISA probe stuff, aic7770.c, aha1742.c, and any other EISA specific driver code. If you are going to fix the ultra14f driver, you might consider writing EISA specific probe/attach routines for it and placing them in another file in sys/eisa (similar to how aic7770.c interfaces with aic7xxx.c). -- Justin T. Gibbs ============================================== TCS Instructional Group - Programmer/Analyst 1 Cory | Po | Danube | Volga | Parker | Torus ==============================================