From owner-freebsd-arm@freebsd.org Tue Aug 30 23:26:03 2016 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BBCC1BC991A for ; Tue, 30 Aug 2016 23:26:03 +0000 (UTC) (envelope-from kevans91@ksu.edu) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0045.outbound.protection.outlook.com [104.47.33.45]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 25486F00; Tue, 30 Aug 2016 23:26:02 +0000 (UTC) (envelope-from kevans91@ksu.edu) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ksu.edu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=r5ihkSLcxSdXjsnZOSt/UrLoSqefwu4mN57aaKqM0JU=; b=eAHn4/tSxOarYTWrRQOhdGut4kegxl/E+Dcz4/ZM04xrDsLNLD5JZ3/Lp/tEoe2Vk13CJbBilL2faHqevJmGz5z+1A/zoJ+jFD40UGniMFqHynoAMAW+Sid79bNoqbY8dts+t0XiWbKCvijFeN/VWRGzz3VtsNuAq3OuGoYbqts= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kevans91@ksu.edu; Received: from mail-qk0-f172.google.com (209.85.220.172) by BN3PR0501MB1316.namprd05.prod.outlook.com (10.160.183.17) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.8; Tue, 30 Aug 2016 20:53:23 +0000 Received: by mail-qk0-f172.google.com with SMTP id l2so31888174qkf.3; Tue, 30 Aug 2016 13:53:24 -0700 (PDT) X-Gm-Message-State: AE9vXwNChRgZu8Xz4Lit7pIWj3ZP9JXzXkHG86tHssQxiCxIKrJ9iuDeDn37lf1DCutmCxaCQyEkQcWLOKDz5g== X-Received: by 10.233.237.4 with SMTP id c4mr6744027qkg.199.1472590396666; Tue, 30 Aug 2016 13:53:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.41.4 with HTTP; Tue, 30 Aug 2016 13:52:56 -0700 (PDT) In-Reply-To: References: From: Kyle Evans Date: Tue, 30 Aug 2016 15:52:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: libm long double functions on ARMv6. To: Warner Losh CC: "freebsd-arm@freebsd.org" , Ngie Cooper X-Originating-IP: [209.85.220.172] X-ClientProxiedBy: CY1PR15CA0009.namprd15.prod.outlook.com (10.163.14.19) To BN3PR0501MB1316.namprd05.prod.outlook.com (10.160.183.17) X-MS-Office365-Filtering-Correlation-Id: 7145a93a-9c7b-4800-924a-08d3d117aeaa X-Microsoft-Exchange-Diagnostics: 1; BN3PR0501MB1316; 2:EGaJEwV5D+U4zqAJvg5dP+YbjVtxHyhswf4yOCI7qCC6aHxJZee5rAv6bbHYybwaVN69/dWowfGNnNXEPjRq/SuPKyvN74rphROBYkR45gAQJ/RYO/80djZ0ZCPX8wtAvV+3b1ZizOZ8Xx/MiVAQ86WbH9IArxHR7X0rJBnBtVGIsomEQP5yjieCPqcSoYJq; 3:Xelsa79XQhgKc+CM7kiKmxIs+ItCz5lhhyFfsmCeaU28/aj6PD6Qa7hf/wdm5T4EghTj73mNrkdCNHnOH/xkbTv+58fRl+70jByavJOSv0m+KOjXysTE5PjVVCFYLMXz X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0501MB1316; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0501MB1316; 25:wKyymGxdpiifIMnffF98IwG/JD17W8CVCMIZnBG?= =?us-ascii?Q?9iWTrIzR6Zjs8heupVR/T72tnVLJH7yy1qHJ3i5SbBZ7L1c+CkSo8ejA1VS9?= =?us-ascii?Q?TaKFBkMVMRPV9N356pO1HL8rQlIZm2Yw8gAq1ZQgPsHVexjjR+npcVTQa348?= =?us-ascii?Q?bjk8e02UOKG/X63P8YCTcPp6kiPFF46NoUI8WovcgRUGT8265ylHgDT9vxTF?= =?us-ascii?Q?meh+ynNo9ZvDv8lVCkwGXTno35Rc/duS+JEWc51abh2mameqQ7Ih31kzhAjD?= =?us-ascii?Q?+qZfMkZRHErobE92ptz/IM1RnV3azh7zVWKc9E1IkmdFMCpBSQNoah81wuj7?= =?us-ascii?Q?T88w2gMAoFhYnB4uLCC+ysk7Q+jBxsVWVMEWdfe3PKREIwN0LzeEVx0SEkkG?= =?us-ascii?Q?LLfi3qWzrGnBM0Zo+3UJ5CUgmKJFhzApZeLolVJjfIj7QVqp4H1FwcMhR4Ux?= =?us-ascii?Q?92urzmQlDiQ3ZlZ//m9+PkF+FdmARNTYqLbpMZPW+D5DukgOZPj6UCNysPT/?= =?us-ascii?Q?3Pvm6IEeLbQfGtxCJwGxw+oQgDewu1LltMoS8r3GMlTsinN6xEp1GDAZpTiT?= =?us-ascii?Q?j1Rjf6c0CkBRZomMjUQAIx1Y1+D4VUuiWm2c1XBVnX9na4+yb2dA6pwcHEhC?= =?us-ascii?Q?2N0BLp+MzzQ0W7r29esVnx2ONY+5n4nv8I05GJ8xEzLz4/uRhy4g05maS86q?= =?us-ascii?Q?kaQd8OLMfFCepZ/5qbD7/ozzxgWEoWKYG0r4hXL2tFwK2bp9tC7D/WY6dBO9?= =?us-ascii?Q?gsUVzrTeMVqRATZHIfNr7MzoSDnjhTtZ5PiKzItKM0Uu/+C9JytydCEJfcQm?= =?us-ascii?Q?IqqIiJquFDagDXjrpfl1Z/mEV5YM8LtLPWwN9NHnFbnEe3/AEh7xcJhh+SX1?= =?us-ascii?Q?PXFr/cOO4QM2BmgiLZuA69W4KHWf/Pb2dQuhfaexeURkDXGpuy81bUQhjT0g?= =?us-ascii?Q?gIbWpKgK6hYO6owltaTeojMLW/aTtD0wiQlWi44HJjA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0501MB1316; 31:GiYT3blUwHBeqZxpoOqlEPfFikh5xTZ5qEyr1ibShI6sMDJq/EGLWq6EaFt8kD4rfsrfyC4HTzxz/gV1t8IpJ40/psCdtxGIQimxob5QGOqpkVdsGmcwFjGFOW8EuR5PSG7B7FW6ZTtCV7Rkaoz4GIbbl6JXu5GcYFQdYp7Qh7MNmYUuSa+98TnhhcO67wSFuHGtNkPXMD6HzLdiTE1L6teG2ZlS1TfmR94GJyuaZic=; 20:fwT0lIu0LFF+eYLTrRnTOCGf3OMsnrNF6rbwpyd1+9OuF4MW3DLrDHsJfFTNwkUrY0VyO4z4vPWTzd6SHCKXKXi9j1CEV3A+OuxRIzaUmCQ085TXO00Vxi03333Hp0cuCpjKUgFO0hZtV6V5cymJe4Ll+9CDI/2NYBzcWz7BwUBfVINQN+w8RkezBvda/2rJYGhj9onEf0Pl9/JWG6LkAM86okOBOBoz2NKgOB4e1E6mJhXhRcz9TjT9+3PsMdtn6CFhxkYc7jcIypMDFOQSB2jVkgo/V9KAMxysAgjlQnhCamL3JwyhyUgABnFJPrVAT2Q52tQ5LNaYfFItFA5SHGuQHOEjO4fU5PR5GNBCy/OW3JUYp6ECH6+9ddspUttgSUNAxey0iTMs6/ClilLVBcxUuaLWQ/EfgaXJFHM+xCSYERxfq8ptJq04tc7GxEA37thUZMzzLpZxyFaE/VsXgIJtPMcPhHlMcGQ/PSQ5D2IxLBuZwMHBtkbMVaRMojr8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(112903893386949); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BN3PR0501MB1316; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0501MB1316; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0501MB1316; 4:pVmTjjDNF4/p5lhjjS2CSZVZcv/ZPz2ZTz97BQzxJnpPJPmlsfncu2m1zjG9SKwMmTLKurmAsFDl/ymqy2r5eD7eA1RlKi8Kootnm8hCC0grbVGYQzGmgBecplcnY+wT6sBXsKcKQ0EmLaoaS3kFT2pcpXvWEh7jToLvdWKJO/XiwhwlB/Yz6Wy55TRlrT/U9sXekO6eZLB1M6JI0WP4dgVlGCeyDTP/pgU0EthUO+jun3FSX47G5R4uULiXgFlIl2UeB+LV1/hdjyXZJYDQ+CKyV2TTZTUZL7IjsVTes/BeVYyCea9n6xhl1q7z1IfXB0qxeVsv8gd1R+QlOVyCnKIJzgqF4Eli0sspFGxWmnLIBBbWJ9XoZ2D41obaiRGtmFNFQ07v5d/24hB6kjMfFYIl8pqmx+mgNzFrfY14vh/2uWoFuC/pO5Dkkg0gk8mL X-Forefront-PRVS: 0050CEFE70 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7916002)(24454002)(189002)(199003)(377454003)(105586002)(76176999)(2950100001)(63696999)(9686002)(19617315012)(15975445007)(512874002)(2906002)(7846002)(54356999)(69596002)(75432002)(81156014)(3846002)(586003)(6116002)(50986999)(7736002)(8676002)(7906003)(42186005)(19580395003)(81166006)(90282001)(88552002)(55446002)(66066001)(189998001)(101416001)(89122001)(86362001)(84326002)(5660300001)(4001450100002)(122856001)(305945005)(106356001)(61726006)(4326007)(97736004)(92566002)(61266001)(9896002)(68736007)(450100001)(19580405001)(59536001)(8576002)(93516999)(110136002)(67856001)(55456009); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0501MB1316; H:mail-qk0-f172.google.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ksu.edu does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0501MB1316; 23:fJR65fxnqmDsJVirFuPmwc9R1UXFZnnF3Dgs5ok?= =?us-ascii?Q?Ep+PXPDGc2PXFRsZbcDpIOmKez5aeoKeQDLqHIrumWAJrUZ5S3LC0AgGZTSM?= =?us-ascii?Q?mbV82M7p6XYN+ybktxC7hTPsyauzRbQegHugHkPXgQIfCSRiFjhaez3yhRvG?= =?us-ascii?Q?eipR9Sa4uhoFDRpIp8SnMXawrSefLDxMmHl2gly+UCQJ14+8MF4BF/+QD5hy?= =?us-ascii?Q?FJYRUcB013p5NFpU8lPXhmjXj9fzkzlTPcSHtQwMXRxNPUBfbx22AOoeH+y3?= =?us-ascii?Q?xgMf5FBCLRaFn2a4uG5Mu5Hy2i85MBi72d80zx4wMLty2y4FuWeeO+6Bb4bj?= =?us-ascii?Q?fL208CFvowejlZes2+I+HfLtli2AIwNlp9lBedV7xg/kkFcytcxKLJbzD9CE?= =?us-ascii?Q?0HjRUSF+emTMqwu3bfuABsgcNr8FCg76elecNmkvtInBzoL+LCGL3Grw6LBg?= =?us-ascii?Q?T9eDLXi4iFEVpGy9AIinA6zEbUU48Uc13renAfM3jdBJ0BgzNl/xdKmGMYqk?= =?us-ascii?Q?MBnkpONiWf6Gnfpo7bZjBZ8mYrcAyb0UiJ16vdzGMtBUgk0TqYsbs/3Dhc1E?= =?us-ascii?Q?QsvM2V/NEEBxmHWUDqJyp9qGbu9LpMchisFVNrrc5J+yxKDIul8taeTifIhY?= =?us-ascii?Q?anRYKmV0UXQ8aidJI4Hq1LFLd+0C3QJigjysFNa6t5ApFILhesXXx8hARBpO?= =?us-ascii?Q?iRq5o7AhCqH7I4E1kWntexYiwkl+pdMp7gQMZshd4eKRvBrVzyC8mnk8fyLi?= =?us-ascii?Q?G578FAmLExpwv/pk2BG+KQg0AlSTn6mTrPQMgyNwsLadcwgqpesjlNu6jHzs?= =?us-ascii?Q?CD//RMJVDONMx8KpIhPU8a7hMFOtoWMYy3VdsffUtA0Bjx1mLq6vIlq9EWcY?= =?us-ascii?Q?Yq2FuSfcgC2kGuhyxK7R9nHPmUsQYDZDuZWFp5huGv1l50cOw1VXVAeYw61C?= =?us-ascii?Q?40B1z6j1agAhkFPZcb5L9Xc98JtX39yeSUw6W+SCQVLFQmdy3XnVBge+4gSh?= =?us-ascii?Q?aA5j19v446h4TWKRo4cz8n39X7LFElat6S29+1qY80Z3oO+uexlqR5HVDUWc?= =?us-ascii?Q?0QuXPQkL9zC/lLiZ+3oXdCK/89gUu3yzo5xJRF6Lrc4KSAOMfcDFi89qr0ah?= =?us-ascii?Q?RvcCScoVwq4PpPC4NH+TgfBZlmld8XoCLtskR8rrZYj5H5vmOLt6xVP4jWaB?= =?us-ascii?Q?5+68dAPQ+OeQyDi0j9Ss+nVnWYQbK5cJTiSuxtinLeohl6L+gJTNEM5RfoKC?= =?us-ascii?Q?HOge3s1Ft7l/p2y51e+QFFfJOk89ocMVdxOZzCjlMu2Zk/nveyR9/pW+tw9v?= =?us-ascii?Q?edsBkDGmGLwcoMhlefY1NLk0OFrwrX2yb8ziWSs8G0D0UpP/m082qJXaxUPW?= =?us-ascii?Q?aeksHrWA7vTPfFIY+jfpLiqxQlH1h7hQ+DGWebULo/rcL8BAJxJpOAz4NUEr?= =?us-ascii?Q?kOYKTpYmdPQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0501MB1316; 6:EHxdPjBhKf9t86foLAdp5O8RfY0oQUKL0TLiSAqrOdAR2nnqrE4ooDVP2H84wjWM0KDgZUlnokk/ITlTCvTl9tH5hz0BwD6T4D1M562a5QxPfGoyWGK90RBYMAXMHebetN7DxyV4OOIiSLWQbe3gan/Q0pHb7GG5ErSm+1ZsGbLR/8/YUlA291XCc/Zg0qBeWvfwklNXqql/Wfwa7pQz9Gzkrorh/ws3mRuwSi5gG/gmyoxcmk+HYjXP3/uETvjBVoVmKmEP+mx9LpxpCnzd16QmFG8vgQyA8zk5WTtOSuc=; 5:p43ZaPkKjtjFdQEo5damEHmcKpDv2Wdb3UTzXgbrvGREmARRuD+QIoUcQbxqoQnfcyaKW3v1eEuE6/LrDxGng7mJM6m4TGhQM8523QposIomd/pbgwhDEfdtthGSw8xWin9Ld44iUMDRTPNhqEGzTw==; 24:mROVcEONz66iZGEuniKdrz2Me/g1P6p36CcZd9lINjr+IIi/fQIgfIkOAU8PAwpzN+/ACmsqfYW/IvsG750dJ5yZmz9It3bTUHqcENWrgY4=; 7:ASa2pkiQloIN02+GCQMB2FDo3jhFqY22DwEyFZq8CGPfZ1bZi+6DlIp7j57TW4hjR6TdH+ukwTbHEHIKvfRBgVikR1pNCmeij1O1+y8lzWdKZ7X9TIcqVSGjc0B3fQNFkeP6bl+tdOjsG1ZeVypga39M9SNXzCLiUYzlckkC/yUKZ86idPSZqay52Gytx1nbRypZ4k7IhGp3jMWTb0L/o5L1y5MRBicWKud8N6yFnALK1jFfkhNpXmRnosNRQPOh SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0501MB1316; 20:QIGa0nP9lh1uxJPq8e4/tWrlSod/YZ+fUZ6A5TsYP0yEZA+8523QrgZxVuxxAZc8GS0PIM5st0AjYHoknwvLpGP6FZy2hmr3TsbBdJuJYDd+oc/yhnrqpd1Ble/qiqvMbafN9O4lX0I9eypYGghqab7ngrB7hs06ZP8O52z8JVg= X-OriginatorOrg: ksu.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2016 20:53:23.4209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0501MB1316 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 23:26:03 -0000 On Thu, Aug 18, 2016 at 10:36 PM, Warner Losh wrote: > On Wed, Aug 17, 2016 at 10:41 PM, Kyle Evans wrote: > > Alright, apologies for the noise. I answered my own question- went > > through the `long double` functions from msun/Makefile:101, and found > > that `fmodl` seems to be the only one that is not properly aliased. > > > > The issue at [1] (r199422) seems to be relevant, so I'm CC'ing both > > emaste@ and ngie@ as interested parties, also hoping for some > > $0.02USD. > > > > I'm inlining a proposed patch at the end of this e-mail to match what > > is currently done for all of the other `long double` functions on > > these platforms where long double == double. > > > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199422 > > > > diff --git a/lib/msun/src/e_fmod.c b/lib/msun/src/e_fmod.c > > index 720aa03..a3578a1 100644 > > --- a/lib/msun/src/e_fmod.c > > +++ b/lib/msun/src/e_fmod.c > > @@ -130,3 +130,8 @@ __ieee754_fmod(double x, double y) > > } > > return x; /* exact output */ > > } > > + > > +#if LDBL_MANT_DIG == 53 > > +__weak_reference(fmod, fmodl); > > +#endif > > This change looks good. Are there other functions that need this > same treatment? > > And shouldn't this be > > #if LDBL_MANT_DIG == DBL_MANT_DIG > > instead? > > Warner > Hello! If you're interested, I've amended the patch on my PR to address consistency issues in all of these similar alias blocks. They're now all standardized on no-parentheses and using LDBL_MANT_DIG == DBL_MANT_DIG instead of the hard-coded 53 to convey the same meaning. You can find this PR here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211965 Thanks, Kyle Evans