From owner-svn-src-head@FreeBSD.ORG Thu Nov 6 10:11:56 2008 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id C797C1065698; Thu, 6 Nov 2008 10:11:56 +0000 (UTC) Date: Thu, 6 Nov 2008 10:11:56 +0000 From: Alexey Dokuchaev To: Dag-Erling Sm??rgrav Message-ID: <20081106101156.GA40311@FreeBSD.org> References: <200811040231.mA42V4EQ083516@svn.freebsd.org> <86skq6gxtn.fsf@ds4.des.no> <20081105.144840.-432836001.imp@bsdimp.com> <864p2l5hf1.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <864p2l5hf1.fsf@ds4.des.no> User-Agent: Mutt/1.4.2.1i Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, alfred@FreeBSD.org, "M. Warner Losh" , src-committers@FreeBSD.org Subject: Re: svn commit: r184610 - in head: lib/libusb20 share/man/man4 sys/conf sys/dev/sound/pcm sys/dev/usb2 sys/dev/usb2/bluetooth sys/dev/usb2/controller sys/dev/usb2/core sys/dev/usb2/ethernet sys/dev/usb... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2008 10:11:56 -0000 On Thu, Nov 06, 2008 at 10:32:02AM +0100, Dag-Erling Sm??rgrav wrote: > "M. Warner Losh" writes: > > Dag-Erling_Sm??rgrav writes: > > > It looks like whoever wrote this went out of their way to find new and > > > creative ways to break just about every style rule we have. > > Not just coding style, but also style of /dev entries, the modules > > style, etc. > > So the question is, why was this code imported at all? Seconded, especially since it says the code was reviewed by you Warner in the commit log. ./danfe