From owner-svn-ports-all@freebsd.org Thu Jan 24 04:51:18 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 762CD14C2693; Thu, 24 Jan 2019 04:51:18 +0000 (UTC) (envelope-from bhughes@freebsd.org) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CB8EB80E4E; Thu, 24 Jan 2019 04:51:17 +0000 (UTC) (envelope-from bhughes@freebsd.org) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5D5B72217E; Wed, 23 Jan 2019 23:51:16 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 23 Jan 2019 23:51:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2xZrD5daDYox2uA1wMTD8/Jj5S3tJmzJO/UJjKUoy 5s=; b=HM6nJfRh9ch5EsKjoFSrA1mLwb+RPPAPF5Qf9flJzP1Mg69jImhAsqQhy 0E3DeZ2EHPShCIaBdfyMQcQ91JE853rYje3ZfvqRf0h9P8kM4duVi3dCSelzPNlf g1QwR3G4rkRlnixR06dGeW5DSdwjW/Wv9eiP0NV0CJzeRiN6sKKmGNBe4w9vmIny r7PWIxoWT2/TnULhF3PzOhjZOkXgG+Qg9sIdiBQ9YC4ovjV8oYF07fkdDz0O+prM eEiZsy7bA3oGC/TxLtKCm+eOg7Xt7bbH76HK0dbgCB5gHsrE+svEavOs1zP7N657 C+u4vTknHXSN0rk0+jsYF/ecjCQoQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledriedugdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucenucfjughrpefuvfhfhfhokffffgggjggtgfesthejredttdefjeenucfhrhhomh epfdeurhgrughlvgihucfvrdcujfhughhhvghsfdcuoegshhhughhhvghssehfrhgvvggs shgurdhorhhgqeenucffohhmrghinhepohhpthhiohhnshdrmhhknecukfhppeejjedrud eirdejhedrheeknecurfgrrhgrmhepmhgrihhlfhhrohhmpegshhhughhhvghssehfrhgv vggsshgurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from [172.20.10.3] (77.16.75.58.tmi.telenormobil.no [77.16.75.58]) by mail.messagingengine.com (Postfix) with ESMTPA id 348A1E4068; Wed, 23 Jan 2019 23:51:14 -0500 (EST) Subject: Re: svn commit: r491058 - head/www/node8 To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201901232114.x0NLERHX020332@repo.freebsd.org> <20190123220008.ctao7hiv4flbms7i@atuin.in.mat.cc> From: "Bradley T. Hughes" Organization: FreeBSD Message-ID: <34d14b33-8cef-2be4-3949-85164661c1ae@freebsd.org> Date: Thu, 24 Jan 2019 05:51:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190123220008.ctao7hiv4flbms7i@atuin.in.mat.cc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CB8EB80E4E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.968,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2019 04:51:18 -0000 On 2019-01-23 23:00, Mathieu Arnold wrote: > On Wed, Jan 23, 2019 at 09:14:27PM +0000, Bradley T. Hughes wrote: >> - >> -.include >> - >> -.if empty(PORT_OPTIONS:MBUNDLED_SSL) >> - >> -.if !empty(SSL_DEFAULT:Mlibressl*) >> -IGNORE= cannot build node.js with LibreSSL. You must enable BUNDLED_SSL >> -.endif >> - >> -.endif > > Mmmm, this is not equivalent, now, the port is always marked as BROKEN > if the op uses libressl* as their default SSL library, even if > BUNDLED_SSL is set. > > And I think the other changes to the other node* ports are also wrong > for the same reason. Good point, I hadn't considered that. I will fix them now :) -- Bradley T. Hughes bhughes@freebsd.org