From owner-freebsd-current@FreeBSD.ORG Mon Jan 5 00:56:10 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A244E106564A; Mon, 5 Jan 2009 00:56:10 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.9.129]) by mx1.freebsd.org (Postfix) with ESMTP id 677678FC17; Mon, 5 Jan 2009 00:56:10 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 7C960730A1; Mon, 5 Jan 2009 02:01:05 +0100 (CET) Date: Mon, 5 Jan 2009 02:01:05 +0100 From: Luigi Rizzo To: Maxim Sobolev Message-ID: <20090105010105.GA47387@onelab2.iet.unipi.it> References: <20090104234238.GA44381@onelab2.iet.unipi.it> <49615475.2030803@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49615475.2030803@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: current@freebsd.org Subject: Re: upcoming elfdump refactoring X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2009 00:56:10 -0000 On Sun, Jan 04, 2009 at 04:29:41PM -0800, Maxim Sobolev wrote: > Luigi Rizzo wrote: > >I need to extract value and size of some symbols from an ELF file, > >and make them available to a C program, something like > > > > nm -S /boot/kernel/kernel | grep -E "(kernload|kernbase|uscanner_devs)" > > > >Rather than using the above tools plus popen() and some parsing code, > >I have refactored src/usr.bin/elfdump/elfdump.c , > >making the main routine externally callable, returning the > >desired info in a struct rather than print them out. > > > >I don't know if/how other programs might need to call elfdump(), > >but given that the changes I made have no functional or performance > >drawback, I would like to commit them to the tree. > >Objections ? > > > >(note, the diff will be large because in the process I also removed > >global variables and staticize/constify things) > > Why not make this function part of libelf? because i was not aware of its existance (also a reason why I posted the request - i didn't want to reinvent the wheel). Thanks for the pointer, I will look at libelf and see if it already contains soemthing that does what i need. cheers luigi