From owner-freebsd-ports@FreeBSD.ORG Sat Jun 23 08:18:47 2012 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9CC46106566B; Sat, 23 Jun 2012 08:18:47 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 596B78FC15; Sat, 23 Jun 2012 08:18:47 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5N8IlDF047019; Sat, 23 Jun 2012 08:18:47 GMT (envelope-from bapt@FreeBSD.org) Received: (from bapt@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5N8Ilg5047018; Sat, 23 Jun 2012 08:18:47 GMT (envelope-from bapt@FreeBSD.org) X-Authentication-Warning: freefall.freebsd.org: bapt set sender to bapt@FreeBSD.org using -f Date: Sat, 23 Jun 2012 10:18:44 +0200 From: Baptiste Daroussin To: Doug Barton Message-ID: <20120623081843.GC41054@ithaqua.etoilebsd.net> References: <4FE12F2D.9080302@FreeBSD.org> <20120620061136.GA79164@ithaqua.etoilebsd.net> <4FE1829D.6030109@FreeBSD.org> <20120620091321.GA83730@ithaqua.etoilebsd.net> <20120620094431.M12775@martymac.org> <20120620103412.GB83730@ithaqua.etoilebsd.net> <4FE1C1EA.8070901@FreeBSD.org> <20120621090226.M48537@FreeBSD.org> <4FE4AEFC.4070405@FreeBSD.org> <4FE51858.4010502@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UFHRwCdBEJvubb2X" Content-Disposition: inline In-Reply-To: <4FE51858.4010502@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: FreeBSD Ports , Olli Hauer , Ganael LAPLANCHE , Matthew Seaman , Michael Scheidell Subject: Re: optionsng and tinderbox? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2012 08:18:47 -0000 --UFHRwCdBEJvubb2X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 22, 2012 at 06:14:00PM -0700, Doug Barton wrote: > On 06/22/2012 10:44, Olli Hauer wrote: > > On 2012-06-21 11:26, Ganael LAPLANCHE wrote: > >> On Wed, 20 Jun 2012 13:28:26 +0100, Matthew Seaman wrote > >> > >>> [...] > >>> Shouldn't make.conf / commandline settings override OPTIONSFILE rather > >>> than the other way round? Seems there's not much point in being able= to > >>> set options from make.conf unless that is so, as OPTIONSFILE would be > >>> created more often than not whenever make(1) was invoked in the port's > >>> directory. > >> > >> I think that command-line options should always override file ones, but > >> the main problem here is that we cannot distinguish what comes from the > >> command line from what comes from make.conf. > >> > >> What would sound logical to me would be the following order of precede= nce : > >> > >> make.conf -> overridden by option files -> overridden by command line > >=20 > >=20 > > This looks wrong to me. > >=20 > > Options set in make.conf should not be overwritten by the option file > > else you don't need etc/make.conf at all. >=20 > Right. make.conf and options files should be flipped in the example above. >=20 >=20 > Doug >=20 Well the priority ordering the logical was to give the end word to the last= user action. It goes from global to specific 1/ the global options (infrastructures) are applied 2/ the maintainer option (ports are applied) 3/ the user global options are applied (OPTIONS_{,UN}SET) 4/ the user ports options are applied (${UNIQUENAME}_{,UN}SET) 5/ the dialog (make config) options are applied If that it looks not good to anyone, please comment (we can still change it= ) and please provide arguments. regards, Bapt --UFHRwCdBEJvubb2X Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/le+MACgkQ8kTtMUmk6EzqqgCfR5aiR1kzt0M3VLNrKl/osNHL 5swAmwVGgxfbfQ9dfUmWwZecZYgghqV4 =PRTs -----END PGP SIGNATURE----- --UFHRwCdBEJvubb2X--