Date: Fri, 26 Aug 2016 18:37:33 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ngie Cooper <yaneurabeya@gmail.com>, Dimitry Andric <dim@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-projects@freebsd.org" <svn-src-projects@freebsd.org> Subject: Re: svn commit: r304868 - projects/clang390-import/lib/clang Message-ID: <51c6c0cd-8809-76d8-bc07-1079e1e7a503@FreeBSD.org> In-Reply-To: <CAGHfRMAYmeQHHnhTfN3GZkcGo9uhKnp_-DYmjANwtqqgkeo=dg@mail.gmail.com> References: <201608262256.u7QMuNaZ037409@repo.freebsd.org> <CAGHfRMCZ9Ma%2B9wfFJ%2BKFkP6KCr6vwE5CHP6fuyDgPvuzpd59PQ@mail.gmail.com> <A241E349-C7E3-490F-ADC9-D25ABCE956B6@FreeBSD.org> <CAGHfRMAYmeQHHnhTfN3GZkcGo9uhKnp_-DYmjANwtqqgkeo=dg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--T9dlm0exhp0vQ0pg2lN8HHTOEtknWk3ia
Content-Type: multipart/mixed; boundary="pXSd53idcXRAmD5CcmeTFmNDbpMmNiEoF"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Ngie Cooper <yaneurabeya@gmail.com>, Dimitry Andric <dim@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
"svn-src-projects@freebsd.org" <svn-src-projects@freebsd.org>
Message-ID: <51c6c0cd-8809-76d8-bc07-1079e1e7a503@FreeBSD.org>
Subject: Re: svn commit: r304868 - projects/clang390-import/lib/clang
References: <201608262256.u7QMuNaZ037409@repo.freebsd.org>
<CAGHfRMCZ9Ma+9wfFJ+KFkP6KCr6vwE5CHP6fuyDgPvuzpd59PQ@mail.gmail.com>
<A241E349-C7E3-490F-ADC9-D25ABCE956B6@FreeBSD.org>
<CAGHfRMAYmeQHHnhTfN3GZkcGo9uhKnp_-DYmjANwtqqgkeo=dg@mail.gmail.com>
In-Reply-To: <CAGHfRMAYmeQHHnhTfN3GZkcGo9uhKnp_-DYmjANwtqqgkeo=dg@mail.gmail.com>
--pXSd53idcXRAmD5CcmeTFmNDbpMmNiEoF
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
On 8/26/2016 5:58 PM, Ngie Cooper wrote:
> On Fri, Aug 26, 2016 at 4:39 PM, Dimitry Andric <dim@freebsd.org> wrote=
:
> ...
>> I used ${SRCTOP} and ${OBJTOP} initially, until I realized that the
>> latter didn't work for builds which are started during bootstrap-tools=
=2E
>> So I locally reverted all these changes before committing this WIP.
>>
>> That said, ${SRCTOP} makes it look a little nicer, but there are lots
>> of other instances of using ../../.. in these Makefiles. It does not
>> really bother me. :)
>=20
> Can you use something like this instead to signal the "right intent",
> and someday hopefully this will just work (tm) with a bit more effort?
> Thanks,
> -Ngie
>=20
> # XXX: SRCTOP isn't available until Y stage in the build
> SRCTOP?=3D ${.CURDIR:H:H}
> LLVM_SRCS=3D ${SRCTOP}/contrib/llvm
>=20
SRCTOP should work just fine here. He did note that 'the latter'
(OBJTOP) wouldn't work, since the early build likely is getting a normal
build OBJTOP/tmp value for OBJTOP since it builds with
MAKEOBJDIRPREFIX=3D${WORLDTMP}
--=20
Regards,
Bryan Drewery
--pXSd53idcXRAmD5CcmeTFmNDbpMmNiEoF--
--T9dlm0exhp0vQ0pg2lN8HHTOEtknWk3ia
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJXwO7dAAoJEDXXcbtuRpfPnGkH+wYrfrzeIzGjZ6/mob3GFyCH
sH0e2iHsiLJe+hNl/FN8QdE48CCAcI9N/p4bVsUcfOlldYNcrhr3EGKW7auoioek
l8mhS9FmbsCP4yFp3Q08JO7jYRfEqPGb8pXDsncO5ligF1s5588zsByEsklWkljN
tCNGE6OKEz90IEFQDfXL5UWQvuiGKgDjgsayrhp+eCGpwO9KjnDJuq9LH6HBuENe
TtylCdVtCEAQNJ+mOTwYzlJhhAGAuMSZbjgrwGPe7ndcdjTGP16lBWJXMvIBOOrN
1qcG3vezd2ptezlRXQ6eX7m9T7KDHB/neQUTq3td6DfjjsbqZzGKjLN0XdwqVKc=
=rEjI
-----END PGP SIGNATURE-----
--T9dlm0exhp0vQ0pg2lN8HHTOEtknWk3ia--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51c6c0cd-8809-76d8-bc07-1079e1e7a503>